For some imports it was useful, that the keyword filter, would only fitler the field, not the whole import item.

CommentFileSizeAuthor
#5 skip_field_only-1372826-5.patch2 KBmerilainen
#2 skip_field_only-1372826-2.patch2 KBderhasi
#1 skip_field_only-1372826-1.patch1.4 KBderhasi

Comments

derhasi’s picture

derhasi commented
Status: Active » Needs review
StatusFileSize
new skip_field_only-1372826-1.patch1.4 KB

Most mappers will do just fine, with an empty value provided (like the fields implementation).

So, there is a patch for this functionality.

derhasi’s picture

derhasi commented
StatusFileSize
new skip_field_only-1372826-2.patch2 KB

Oh, I missed the non regex part. A modified patch is attached.

merilainen’s picture

merilainen commented

I have used this in two projects and it has proven to be very useful.
But I get this error after applying the patch:

Deprecated function: Call-time pass-by-reference has been deprecated in ctools_plugin_load_includes() (line 475 of /Users/username/Sites/sitename/drupal/builds/build_2012-12-03-130253/sites/all/modules/contrib/ctools/includes/plugins.inc).

Status: Needs review » Needs work

The last submitted patch, skip_field_only-1372826-2.patch, failed testing.

merilainen’s picture

merilainen commented
Status: Needs work » Needs review
StatusFileSize
new skip_field_only-1372826-5.patch2 KB

There were function calls with the &$field, when it should be just $field. This patch fixes it.

twistor’s picture

twistor commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs tests

Looks ok, there have been some changes.

Sorry that I missed this.