Allow developers to pass options via $this->plugin['redirect'][*] similar to how core $form_state['redirect'] works

When we have the same code 4 times, and it's now 3 lines of code, this is a clear sign that we should abstract.

Something like this would work as an export ui class method: (this is just off the top of my head, no testing or verifying):

  /**
   * Perform a drupal_goto() to the location provided by the plugin for the operation.
   *
   * @param $op
   *   The operation to use. A string must exist in $this->plugin['redirect'] for this operation.
   * @param $item
   *   The item in use; this may be necessary as item IDs are often embedded in redirects.
   */
  function redirect($op, $item = NULL) {
     $destination = (array) $this->plugin['redirect'][$op];
     if ($item) {
       $export_key = $this->plugin['export']['key'];
       $destination[0] = str_replace('%ctools_export_ui', $item->{$export_key}, $destination[0]);
    }
    call_user_func_array('drupal_goto', $destination); 
  }

This also incidentally makes the variable name more meaningful.

Maybe if $op is not set in the plugin, the redirect should fall back to the base path; it doesn't feel right for the redirect to not actually perform a goto and fail silently if somehow the op is not set.

Committed and pushed! Thanks!

Could someone explain/show example code of how this should work?

I tried adding this in panels_mini.inc (a export_ui plugin in panels core):

  'redirect' => array(
    'edit' => 'user'
  ),

Unfortunately my specified redirect get's overridden with this code in ctools/includes/export_ui.inc:

  // Define some redirects that should happen after edit/add/clone operations.
  $plugin['redirect'] = array(
    'add' => $base_path,
    'clone' => $base_path,
    'edit' => $base_path,
    'import' => $base_path,
  );

Either the code above should only append to $plugin['redirect'] or I have completely missuderstood how this should be implemented..

I got it working by changing the code above with this:

  $plugin['redirect'] = isset($plugin['redirect']) && is_array($plugin['redirect']) ? $plugin['redirect'] : array();

  // Define some redirects that should happen after edit/add/clone operations.
  $plugin['redirect'] += array(
    'add' => $base_path,
    'clone' => $base_path,
    'edit' => $base_path,
    'import' => $base_path,
  );

I wasn't sure if I had missunderstood this completely so I didn't do a patch. I'll do it if you want me to.

I was trying to solve this issue: #934738: Don't redirect on update and save for mini panels

What I would like to do is basically say don't redirect at all. From what I can see there is no way to do that? You either specify a location to redirect to or it will redirect to the plugins base path, there is no way to only display the form again. Which is what I want.

Yeah, but first I'd like to be sure that I've implemented this new feature correctly. Could someone please explain or point to an example of how/where you specify the redirect path.