Not a bug in the code and maybe I'm nitpicking but this is a problem that is causing confusion.

There are two downloads with the same file names but are not the the same.

Linked to at the top of the project page. This contains all of Drupal
http://www.opendealsapp.com/releases/opendeals-7.x-1.0-alpha4.tar.gz

Down in the "normal" download area. This is the distribution only.
http://ftp.drupal.org/files/projects/opendeals-7.x-1.0-alpha4.tar.gz

This really confused me for a while since I had downloaded the second one and the instructions to "Install as you would install Drupal" didn't make sense.

I think it's the reason for these two threads
http://drupal.org/node/1360588
http://drupal.org/node/1355304

The Kickstart project has avoided this with just one download in the normal place.

I guess it makes sense to have both but perhaps they should be different file names.

Also, despite what is said in http://drupal.org/node/1360588, OPEN_DEALS_README.txt does not seem to be in the distribution.

The project looks good, thanks.

Comments

icosa’s picture

icosa commented

Just to add another nitpick in the interests of consistancy:

The file http://www.opendealsapp.com/releases/opendeals-7.x-1.0-alpha4.tar.gz does not seem to be packaged the same way as Drupal core and other modules. The convention seems to be to put the files into a subdirectory but this one starts at the root. It can cause a surprise when someone follows "Install as you would install Drupal".

yannisc’s picture

yannisc commented

Thanks icosa for the feedback. Your comments seem logical to me and we'll fix these issues in the next version.

nchar’s picture

nchar commented
Status: Active » Closed (fixed)

It is now fixed. I commited the drupal-org.make file as instructed by drupal docs and the package is now complete.

nchar’s picture

nchar commented
Issue summary: View changes

A few more thoughts.