Using pressflow 6.22 with E_NOTICE on, I get

Only variables should be passed by reference
      /sites/all/modules/content_profile/content_profile.rules_defaults.inc
      line 13
CommentFileSizeAuthor
#2 content_profile-1373544-only-variables-should-be-passed-by-reference.patch583 bytesjaapjan

Comments

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented

Bump... I'm seeing this too. Same conditions.

jaapjan’s picture

jaapjan commented
StatusFileSize
new content_profile-1373544-only-variables-should-be-passed-by-reference.patch583 bytes

See attached patch.

kenianbei’s picture

kenianbei commented
Status: Active » Needs review

Same issue here, patch removed warning.

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
Status: Needs review » Reviewed & tested by the community
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 6.x-1.0 » 6.x-1.x-dev
Issue tags: +Quick fix

Thanks @jaapjan that patch works, possibly consider this one too it may be slightly faster:
http://stackoverflow.com/questions/6698428/return-first-key-of-associati...

Either way this is still RTBC.

roball’s picture

roball commented
Issue summary: View changes

Can confirm that the patch eliminates the PHP error under PHP 5.4. However, it doesn't seem that it ever gets committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: -PHP 5.3 compatibility. pressflow +PHP 5.4, +PHP 5.3