Closed (fixed)
Project:
Drupal core
Component:
theme system
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
1 Dec 2004 at 08:48 UTC
Updated:
1 Apr 2005 at 09:15 UTC
Jump to comment: Most recent file
There was a major theming issue I missed in my bug-testing after the multi-site patch landed.
Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all).
The attached patch fixes this situation.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | theme_settings2.patch | 722 bytes | jhriggs |
| #5 | theme_settings.patch | 45 bytes | jhriggs |
| #4 | themes-bugfix_and_cleanup.patch | 8.77 KB | TDobes |
| fix-styles-after-multisite.patch | 632 bytes | TDobes |
Comments
Comment #1
TDobes commentedNote: This might also warrant an update.inc script. Because of this change, sites that were based on styles won't load the proper theme after upgrading until the admin visits the themes administration page an clicks "save."
Comment #2
dries commentedCommitted.
Comment #3
moshe weitzman commentedComment #4
TDobes commentedI did a bit more testing of the theme administration in 4.6 and found a few items that needed improvement.
The attached patch fixes a couple bugs, removes some code rot, and cleans up the code a bit:
* Fix a bug which would cause the "configure" link for styles to be broken. (missed this in the last patch)
* Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme)
* Correct an inaccurate comment in theme.inc
* Populate the default primary links with an "edit primary links" link for consistency with the secondary links
* remove some unnecessary variables in the theme administration which had misleading and confusing names
* replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists
* usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.)
Please commit and/or review prior to 4.6 release.
Comment #5
jhriggs commentedThis patch was applied by Dries but not marked as fixed; however, it introduced a new bug. Theme-specific settings no longer work. The attached patch fixes this.
Comment #6
jhriggs commentedWell that didn't work. I'll try again.
Comment #7
TDobes commentedSorry about that... dumb mistake on my part. When will I learn to clear the menu cache regularly?
+1 to jhriggs' patch, which fixes things as promised. (note that the menu cache also needs to be cleared to fix the bug)
Comment #8
Steven commentedApplied to HEAD.
Comment #9
(not verified) commented