I *think* the text "Fully qualified URL" (hence: Fully qualified Uniform Resource Locator) displayed as help text when adding a feed for the field URL is not clear and redundant.

The combination of "Fully qualified" and "URL" is weird, a URL is per definition fully qualified and includes a scheme (e.g. "http://") otherwise it would have been a URN (Uniform Resource Name). Stricly speaking, it should read URI (Uniform Resource Identifier) since an RSS feedd can be in the form of http://example.com/something/else#type=feed or so.

But URI's are not that well known.

Neither is the term "fully qualified", most Drupal administrators dont know what a FQDN is or need to know it. So I propose to change the help text
"The fully-qualified URL of the feed."
to
"The URL of the feed"

What do you think?

Comments

wim leers’s picture

Version: 5.x-dev » 6.x-dev

Fully agreed.

sipes’s picture

I can agree with this as well, though as I am currently having issues with the aggregator, I think more than a change is in order. I am trying to acquire add URL from a twitter search feed, which can be added to google reader. Though it is the URL of the feed, and it allows me to add it to the aggregator, it does not work. I found through multiple searches that I should check the URL here at http://feedvalidator.org, so I did.

http://feedvalidator.org/check.cgi?url=http%3A%2F%2Fsearch.twitter.com%2....

Which tells me it does not validate, so at this point what is it?

I suppose according to the current help file it is not "The fully-qualified URL of the feed", though it is "The URL of the feed."

wretched sinner - saved by grace’s picture

Version: 6.x-dev » 7.x-dev

Bump to 7.x. Will have a look at this myself

wretched sinner - saved by grace’s picture

Component: aggregator.module » user interface text
Priority: Minor » Normal
Status: Active » Needs review
StatusFileSize
new2.65 KB

I have attached a patch which changes the "fully-qualified" URL text into "complete" URL text. (3 occurances - 2x UI text, 1 comment)

As I was reading the comments and the user facing text, I could see that some adjective was required, and I think that complete seems to fill the roll, as oppose to someone leaving off part of the URL (like the http:// for example)

xano’s picture

Issue tags: +Needs screenshots

Another reason not to call the URL 'fully qualified' is that there is no clear meaning of those two words in this context: "Fully qualified"? What is that? Heck, I'll just enter it anyway.

At the moment I'm with Bert on his The URL of the feed, although I'd really much like to see a screenshot of both versions.

Status: Needs review » Needs work

The last submitted patch failed testing.

wretched sinner - saved by grace’s picture

Status: Needs work » Needs review
StatusFileSize
new2.62 KB

Updated patch to fix path issues.

Will try to post screenshots in next day or two, unless someone beats me to it.

wretched sinner - saved by grace’s picture

I have attached screenshots of current view, and the two textual options. The patches attached match the screenshots. The "the-complete-url" patch is the same as in #7.

wretched sinner - saved by grace’s picture

Issue tags: -Needs screenshots

Remove tag - screenshots posted.

cburschka’s picture

Status: Needs review » Needs work

I like the second (non-complete) patch, but The URL %url is invalid. Please enter the URL of the feed sounds awkward. Let's call it a URL on normal descriptions, and a complete URL on error messages, for emphasis? Your change to comment.module (in the same non-"complete" patch) does it that way, and it sounds clearer.

figaro’s picture

One comment that might be in order in view of the latest Usability initiatives under way at present: could we hyperlink the acronym "URL" to its definition? I dont think hyperlinking text is a Drupal coding standard, so perhaps there are other ways to help the user find what is expected in the field.

Tor Arne Thune’s picture

Version: 7.x-dev » 8.x-dev

Still a valid issue after the release of 7.0. Moving to 8.x.

Tor Arne Thune’s picture

Double-post.

jhedstrom’s picture

Issue summary: View changes
Issue tags: +Needs issue summary update

From what I can tell, the only place "fully qualified" is still used in the UI is in UrlHelper:

throw new \InvalidArgumentException(SafeMarkup::format('A path was passed when a fully qualified domain was expected.'));

At the very least, this issue needs a summary update.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pameeela’s picture

Status: Needs work » Closed (outdated)
Issue tags: +Bug Smash Initiative

I originally updated the IS and even considered patching the remaining instance (it is still there in UrlHelper). But the original issue had a problem with 'fully qualified URL' whereas 'fully qualified domain' has a specific meaning and I believe it is used correctly in this case.

Marking closed (outdated).