I *think* the text "Fully qualified URL" (hence: Fully qualified Uniform Resource Locator) displayed as help text when adding a feed for the field URL is not clear and redundant.
The combination of "Fully qualified" and "URL" is weird, a URL is per definition fully qualified and includes a scheme (e.g. "http://") otherwise it would have been a URN (Uniform Resource Name). Stricly speaking, it should read URI (Uniform Resource Identifier) since an RSS feedd can be in the form of http://example.com/something/else#type=feed or so.
But URI's are not that well known.
Neither is the term "fully qualified", most Drupal administrators dont know what a FQDN is or need to know it. So I propose to change the help text
"The fully-qualified URL of the feed."
to
"The URL of the feed"
What do you think?
Comments
Comment #1
wim leersFully agreed.
Comment #2
sipes commentedI can agree with this as well, though as I am currently having issues with the aggregator, I think more than a change is in order. I am trying to acquire add URL from a twitter search feed, which can be added to google reader. Though it is the URL of the feed, and it allows me to add it to the aggregator, it does not work. I found through multiple searches that I should check the URL here at http://feedvalidator.org, so I did.
http://feedvalidator.org/check.cgi?url=http%3A%2F%2Fsearch.twitter.com%2....
Which tells me it does not validate, so at this point what is it?
I suppose according to the current help file it is not "The fully-qualified URL of the feed", though it is "The URL of the feed."
Comment #3
wretched sinner - saved by grace commentedBump to 7.x. Will have a look at this myself
Comment #4
wretched sinner - saved by grace commentedI have attached a patch which changes the "fully-qualified" URL text into "complete" URL text. (3 occurances - 2x UI text, 1 comment)
As I was reading the comments and the user facing text, I could see that some adjective was required, and I think that complete seems to fill the roll, as oppose to someone leaving off part of the URL (like the
http://for example)Comment #5
xanoAnother reason not to call the URL 'fully qualified' is that there is no clear meaning of those two words in this context: "Fully qualified"? What is that? Heck, I'll just enter it anyway.
At the moment I'm with Bert on his The URL of the feed, although I'd really much like to see a screenshot of both versions.
Comment #7
wretched sinner - saved by grace commentedUpdated patch to fix path issues.
Will try to post screenshots in next day or two, unless someone beats me to it.
Comment #8
wretched sinner - saved by grace commentedI have attached screenshots of current view, and the two textual options. The patches attached match the screenshots. The "the-complete-url" patch is the same as in #7.
Comment #9
wretched sinner - saved by grace commentedRemove tag - screenshots posted.
Comment #10
cburschkaI like the second (non-complete) patch, but
The URL %url is invalid. Please enter the URL of the feedsounds awkward. Let's call it a URL on normal descriptions, and a complete URL on error messages, for emphasis? Your change to comment.module (in the same non-"complete" patch) does it that way, and it sounds clearer.Comment #11
figaro commentedOne comment that might be in order in view of the latest Usability initiatives under way at present: could we hyperlink the acronym "URL" to its definition? I dont think hyperlinking text is a Drupal coding standard, so perhaps there are other ways to help the user find what is expected in the field.
Comment #12
Tor Arne Thune commentedStill a valid issue after the release of 7.0. Moving to 8.x.
Comment #13
Tor Arne Thune commentedDouble-post.
Comment #14
jhedstromFrom what I can tell, the only place "fully qualified" is still used in the UI is in
UrlHelper:throw new \InvalidArgumentException(SafeMarkup::format('A path was passed when a fully qualified domain was expected.'));At the very least, this issue needs a summary update.
Comment #23
pameeela commentedI originally updated the IS and even considered patching the remaining instance (it is still there in UrlHelper). But the original issue had a problem with 'fully qualified URL' whereas 'fully qualified domain' has a specific meaning and I believe it is used correctly in this case.
Marking closed (outdated).