The current implementation uses this line: variable_get('advagg_js_cdn_jquery_update_version', '1.3.2');, however that variable is nowhere to be seen in the rest of advagg!
I propose we use the jquery_update_get_version() function to fill in the the jquery version string.
This is particularly useful because there are lots of stable 1.5+ jquery_update forks going around (I'm actually using 1.7.1 on a couple production websites) so this way we avoid having to patch advagg and leave it to jquery_update to tell us what the version to load from the CDN is.
Patch attached! :)
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | advagg-1374098-1.patch | 1.15 KB | mikeytown2 |
| advagg_js_cdn-jquery_update-version.patch | 1.07 KB | alexweber |
Comments
Comment #1
mikeytown2 commentedWhere that logic came from: http://drupal.org/node/1071624#comment-4401842
This is the patch that I've committed.