This may be a simple question, on site using splash module enabled running update.php results in WSOD. If splash is disabled it works fine. Splash setting for when is "always".

Tried update.php?splash=off but still fails with WSOD.

How can i run update without disabling splash each time?

CommentFileSizeAuthor
#4 splash-1374114-maintenance-mode-2.patch546 bytespenyaskito
#2 splash-1374114-maintenance-mode.patch535 bytespenyaskito

Comments

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Priority: Normal » Major

Running the same problem. The README.txt says using the splash url param, and this solves the issue (put update.php?op=info&splash=off as the URL).

BTW, I think that this is a bug that must be addressed. Updating priority to major because it breaks #DX.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new splash-1374114-maintenance-mode.patch535 bytes

A patch for fixing this.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new splash-1374114-maintenance-mode-2.patch546 bytes

New patch, the previous one broke the splash behavior.

izmeez’s picture

izmeez commented

Haven't tested the patch yet but have some questions:
1. This patch appears to be dependent on being in maintenance mode which may not always be the case, such as in testing or dev.
2. With this patch is it not necessary to include update.php?splash=off in url?

izmeez’s picture

izmeez commented
Title: Splash, can't run update.php when spalsh enabled » Splash, can't run update.php when splash enabled

just fixing typo in title

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Hi izmeez,

1. This patch appears to be dependent on being in maintenance mode which may not always be the case, such as in testing or dev.

The patch makes that if MAINTENANCE_MODE is defined, the splash is never shown. This means, if you enable the maintenance mode or if you are updating your site. This has no effect on other situations.

2. With this patch is it not necessary to include update.php?splash=off in url?

No, it's not necessary anymore for update.php :-)

izmeez’s picture

izmeez commented

So if the site is not in maintenance mode you cannot run update.php ?

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Yes, you can. But the update.php page sets the MAINTENANCE_MODE to 'update'.

mail@victorquinn.com’s picture

mail@victorquinn.com commented
Status: Needs review » Closed (fixed)

Thanks for the patch penyaskito! Looks great! Now applied to 6.x-2.x