When using the standard Upload Attachment mechanism with Story nodes, listings of stories have the a set of links below each story's teaser. This set of links reads similar to: "add new comment | 31 reads | 1 attachment". Hovering over the "1 attachment" link presents a tooltip that reads "Read full article to view attachments."
WebFM_attachment seems to be missing this functionality. Without it, there is no link to click on that takes one to the full story node page so that the user can see - and access - attachments.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | webfm.module.patch | 1.1 KB | robmilne |
Comments
Comment #1
robmilne commentedThanks for pointing that out - I wasn't aware of this behaviour. I'll take a look at this when I get my life back and can spend some time enhancing this module again.
Comment #2
jraper@groups.drupal.org commentedGreat thanks. By the way - it is a wonderful module. We were previously using Fileshare and have completely replaced it on all of our sites with WebFM. We find it superior in every way.
Comment #3
robmilne commentedThanks for the appreciation. Too bad my manager at Web Networks didn't feel this way when I wrote the module. Too many non-billable hours of R&D.
Comment #4
robmilne commentedPiece of cake. Attached is the 5.1 patch. The 4.7 change is identical so I'll leave that for you to do manually (my working copy of 4.7 is out of synch).
Comment #5
robmilne commentedI owe the 4.7 branch an update to stay in synch with 5. This fix will be part of that release.
Comment #6
jraper@groups.drupal.org commentedThanks for the quick response, but the patch doesn't seem to work correctly. First, it produces two Attachment tables (each with the attached files in them). Second, the link text on the teaser page that is supposed to read "# attachments" with a link to the full node rather reads "Array" and is not linked.
Or is there more that I need to do than simply incorporate the patch into webfm.module?
Comment #7
robmilne commentedI only tested the 5.1 version for this change and it worked fine. The patch file is for 5.1 and cannot be applied automatically to 4.7! The fact that you are seeing crap displayed (and two tables?) would suggest to me that you applied this patch to your 4.7 module.
I'll test a 4.7 install tonight and generate a 4.7 patch.
Comment #8
robmilne commentedOK, I generated a completely new release for 4.7 that fixes this issue (as well as other fixes that were implemented in 5.x-1.5)
Comment #9
jraper@groups.drupal.org commentedThe update DOES fix the link problem, but when I click on the link (to go to the story node) the presented node still has two (2) copies of the Attachment table - one above the "add new comment" link and one below it.
Comment #10
jraper@groups.drupal.org commentedThe update DOES fix the link problem, but when I click on the link (to go to the story node) the presented node still has two (2) copies of the Attachment table - one above the "add new comment" link and one below it.
Comment #11
jraper@groups.drupal.org commentedThe update DOES fix the link problem, but when I click on the link (to go to the story node) the presented node still has two (2) copies of the Attachment table - one above the "add new comment" link and one below it.
Comment #12
jraper@groups.drupal.org commentedThe update DOES fix the link problem, but when I click on the link (to go to the story node) the presented node still has two (2) copies of the Attachment table - one above the "add new comment" link and one below it.
Comment #13
jraper@groups.drupal.org commentedOops - sorry about all the submits. I was getting an "Internal Server Error" in response to my submissions and did not realize they were actually getting posted.
Comment #14
robmilne commentedI haven't seen this behaviour. Is it possible that you have the attachment block enabled and sitting below the content area?
Comment #15
jraper@groups.drupal.org commentedOutstanding - your are correct!
Now everything looks perfect. Thanks again for a great module.
Comment #16
(not verified) commented