See meta issue #1373884: [meta] Core does not use hook_hook_info().

Core modules should support hook_hook_info(), even if not implemented in core code usage.

CommentFileSizeAuthor
#10 drupal--1375002--aggregator-hook-info-D7--10.patch1.04 KBamontero
#5 1375002-aggregator-hook-info_01.patch756 bytesxano
#1 1375002-aggregator-hook-info.patch824 bytesagentrickard

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review
StatusFileSize
new 1375002-aggregator-hook-info.patch824 bytes

And the patch.

amontero’s picture

amontero
Location Barcelona
commented

#1: 1375002-aggregator-hook-info.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1375002-aggregator-hook-info.patch, failed testing.

amontero’s picture

amontero
Location Barcelona
commented
Status: Needs work » Needs review

#1: 1375002-aggregator-hook-info.patch queued for re-testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new 1375002-aggregator-hook-info_01.patch756 bytes

I couldn't find any reference to a hook_aggregator_fetch(). The patch removes this hook from the implementation, and uses array_fill_keys() rather than a foreach().

amontero’s picture

amontero
Location Barcelona
commented

#5: 1375002-aggregator-hook-info_01.patch queued for re-testing.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Closed (works as designed)

none of those hooks exist anymore.dunno if this needs backport? closing, feel free to reopen for 7.x

amontero’s picture

amontero
Location Barcelona
commented

Hi Paris, I still can find its documentation at http://api.drupal.org/api/drupal/core%21modules%21system%21system.api.ph...
and the parent meta issue is still active and does not mention anything about this on 8.x.
Also, grepping for hook_hook_info still gives plenty of results. Please, can you link the relevant issue? TIA.

ParisLiakos’s picture

ParisLiakos commented

i mean for the aggregator hooks inside the patch, not hook_hook_info

amontero’s picture

amontero
Location Barcelona
commented
Version: 8.x-dev » 7.x-dev
Status: Closed (works as designed) » Needs review
StatusFileSize
new drupal--1375002--aggregator-hook-info-D7--10.patch1.04 KB

Oh, now I see. Sorry.
Moving to 7.x with patch attached.

amontero’s picture

amontero
Location Barcelona
commented
Issue summary: View changes

Changes issue reference.

dpi’s picture

dpi
Location Perth, Australia
commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)
Parent issue: » #1373884: [meta] Core does not use hook_hook_info()
Related issues: +#2233261: Deprecate hook_hook_info groups, mark hook_hook_info() for deletion