Closed (fixed)
Project:
CRM Core
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
19 Dec 2011 at 01:06 UTC
Updated:
9 Jan 2019 at 23:51 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedAdded search support for activities as well.
Comment #2
dealancer commented@kevee, thanks for a great patch! I appreciate your help. Looks like it is working very nice for contacts! Here is my review:
This is because crm_core_activity_view() is declared in crm_core_activity_ui. I think, that it is a design flaw and we need to move crm_core_activity_view() to crm_core_activity module.
P.S.
In a future work on a search we could also add some conditions (e.g. entity type, etc).
Comment #3
dealancer commentedYeah, it needs work now.
Comment #4
dealancer commentedI am working on this patch.
After I have moved crm_core_activity_view() into crm_core_activity module, i've fund that activity search is not working, because of the drupal bug: #1425622: Increase length of 'type' field in search_dataset, search_index tables from 16 to 64.
After I have fixed drupal search bug, activity was still not working cause of the call to the crm_core_activity_type_get_name() which does not exist yet, we need to use crm_core_activity_type_name() instaead.
Comment #5
dealancer commentedThis patch was updated and committed, code will appear soon in the public repo.
However we need to reprove search abilities, which requires crm_core changes. What can be improved:
- ability to search in the entity tiles
- disable theme before rendering as it is done in node module: http://drupalcode.org/project/drupal.git/blob/refs/heads/7.x:/modules/no...
- ability to disable field labels from indexing
I am going to create separate issue for that.
Comment #6
Anonymous (not verified) commentedAs long as the items from #5 are going into a separate issue, this issue is closed.
Comment #7
Anonymous (not verified) commentedAgreed, improvements can also come to the crm_core views per this issue:
#1369618: Fullname filter for views
Comment #8
franzAFAIK the search integration is actually not complete before those issues are fixed. So I think this issue should remain open to track that down, otherwise people will have a harder time finding out what needs to be done. Do we have links for them already?
Comment #9
dealancer commentedYeah, this issue depends on #1425622: Increase length of 'type' field in search_dataset, search_index tables from 16 to 64. I am updating status of this issue, cause there is nothing to do yet.
Comment #10
Anonymous (not verified) commentedThis appears to work now.