Revealed via #1373142: Use the Testing profile. Speed up testbot by 50%
Note: The testbot has no issues with detecting and running the tests in this file. They were just not exposed in the SimpleTest group in the UI (except for one being located in another .test file).
Attached patch is a stop-gap fix, does not fix the underlying issue. I suspect a bug in the class registry parser.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | simpletest-description-1376164-12.patch | 985 bytes | oriol_e9g |
| #6 | drupal8.simpletest-tests.6.patch | 1005 bytes | sun |
| #3 | drupal8.simpletest-tests.3.patch | 1006 bytes | sun |
| drupal8.simpletest-tests.0.patch | 1.13 KB | sun |
Comments
Comment #1
xjmI think this is totally appropriate as a quick fix (edit: since escaped quotes are ugly anyway), so long as we open a followup issue to actually track down the parser issue.
Comment #2
dave reidAgreed. RTBC.
Comment #3
sunRemoved the @todo.
Comment #4
David_Rothstein commented"simplicitly"??
I also don't think the @todo is necessary; the new version is using correct code style and the old one wasn't, so there's no reason to ever switch it back.
Comment #5
David_Rothstein commentedOops, crosspost, but the "implicitly" => "simplicitly" change is still in there.
Comment #5.0
David_Rothstein commentedd.o hiccup
Comment #6
sunFixed "implicitly."
Comment #7
xjmSo I can't reproduce the test not being listed with a fresh install of D8; I'm wondering if the functional bug was a registry caching issue from pulling new changes into an existing D8 install.
I still think the reformatting is good, though, so retitling for scope.
Comment #8
David_Rothstein commentedComment #9
webchickOne other annoying grammar thing: It should be APIs rather than API's. http://theoatmeal.com/comics/apostrophe Can be fixed prior to commit.
But channeling catch, I believe he would want to see the follow-up issue to get to the bottom of the root cause of this cross-linked here prior to commit. :)
Comment #10
catchYeah I would, but I also want tests to be 45% faster, so I opened it at #1379940: Track down registry and/or simpletest parser issue that was fixed by some formatting changes :)
Committed/pushed to 8.x (as well as a sneaky follow-up).
Comment #11
sunActually, I was no longer able to reproduce this bug. Someone else in IRC (not sure whether it was @xjm) was able to reproduce it like me at the beginning, but then also not anymore. Mysterious! :)
Since this only affected SimpleTest UI and at least the testbot did not skip those tests (which is how I discovered it when I wanted to run the failing tests locally), and because no one is able to reproduce it currently, I'm going to close the other issue.
The string formatting fix can still be backported though.
Comment #12
oriol_e9gComment #13
sunComment #14
webchickOk, seems like fine in terms of consistency, then.
Committed and pushed to 7.x. Thanks!
Comment #16
cweagansUpdating tags per http://drupal.org/node/1517250
Comment #16.0
cweagansClarified summary.