My test site name contains a / character, which becomes part of the path for the XHProf output file. This was silently failing to produce any output, for obvious reasons.

First, I think there should be some error handling in the fopen() call. At the very least a watchdog() would have saved me lots of time.

And here's a patch for the problem, itself.

CommentFileSizeAuthor
#5 xhprof-1376416-5.patch591 bytesgapple
xhprof-site_name.patch484 bytesgribnif

Comments

erikwebb’s picture

Version: 7.x-1.0-beta2 » 7.x-1.x-dev
Status: Active » Reviewed & tested by the community

Solves the problem for me.

msonnabaum’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed this, but also added "." to replacements, since that can break it too.

  • Commit 795cca2 on 7.x-1.x by msonnabaum:
    Issue #1376416 by Gribnif: Output silently fails when site_name contains...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gapple’s picture

Status: Closed (fixed) » Needs review
StatusFileSize
new591 bytes

The previous patch was incomplete.

While the files are saved successfully, the runs page can no longer list anything since the glob pattern is still using the original characters.

osopolar’s picture

Title: Output silently fails when site_name contains / » Output silently fails when site_name contains / or .
Status: Needs review » Reviewed & tested by the community

Works for me too.

  • andypost committed a9eff66 on 7.x-1.x authored by gapple
    Issue #1376416 by Gribnif, gapple: Output silently fails when site_name...
andypost’s picture

Status: Reviewed & tested by the community » Fixed
andypost’s picture

gapple’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.