Closed (fixed)
Project:
rules_monitor
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Dec 2011 at 20:47 UTC
Updated:
15 Jan 2012 at 22:50 UTC
Jump to comment: Most recent file
When running the test:
sites/default/files/simpletest/verbose/StateRulesViewsTestCase-44.html
Fatal error: Call to undefined function drupal_map_assoc() in /path/to/rules/includes/rules.core.inc on line 989
Not sure why this happens, and there are no other reports about this as of this writing.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 1376552-10-add-test-coverage.patch | 1.01 KB | alberto56 |
| #8 | 1376552-8-test-cron-call-one-day-later.patch | 1.3 KB | alberto56 |
| #1 | rules-error.txt | 39.24 KB | alberto56 |
Comments
Comment #1
alberto56 commentedHere is the print_r of the backtrace of this.
Comment #2
alberto56 commentedHmmm doing the exact same thing outside of simpletest works fine. Something to do with simpletest's bootstrap? No, still nothing on Google :(
Comment #3
alberto56 commentedHa! Adding this:
at line 989 of path/to/modules/rules/includes/rules.core.inc
and *all* the tests pass!
Boosting to major, and this is therefore linked to #1376604: Test "Mail has been sent if a comment is present and more than a day has passed since the last processing." failing
Comment #4
alberto56 commentedWhy did at least one of the previous calls to cron work, then?
Comment #5
alberto56 commentedI requested assistance from the Rules team: #1376688: Load common.inc before serializing a variable (during caching), as objects may trigger code in __sleep() while being serialized
Comment #6
alberto56 commentedSending a mail just before running cron touches this off. Weird.
Comment #7
alberto56 commentedThis is actually not a bug with this module, but rather has to do with the fact that Drupal does not include common.inc before serializing some variables during caching. More info here:
- #1386424: Do not assume that common.inc has been loaded during __sleep()
- #1376688: Load common.inc before serializing a variable (during caching), as objects may trigger code in __sleep() while being serialized
Comment #8
alberto56 commentedI have submitted patches for review for both the issues referenced in comment 7, and if either patch gets in, all our tests will pass. However, until such a time, I have removed the part of the test that fails because of these issues and committed the change to MASTER. I will leave this issue open until one or the other or both of those issues are resolved and I can completely test this module.
The enclosed patch should be reapplied once one or the other of the two issues in comment 7 are fixed.
Comment #9
alberto56 commentedComment #10
alberto56 commentedThis is the patch which should be applied, rather than the one at comment 8.
Comment #11
alberto56 commentedNo longer a problem since #1376546: states should be conditions, not events -- cron is the event has been fixed.
Comment #12.0
(not verified) commentedadded google link