Facet API defines a lot of hooks, so it should implement hook_hook_info() so that modules can group their implementations in a MODULE.facetapi.inc include file.

CommentFileSizeAuthor
#3 facetapi-1376586-3.patch9.87 KBcpliakas
#2 facetapi-1376586-2.patch5.81 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented

If we separated out all hooks other than hook_facetapi_searcher_info() into a facetapi.facetapi.in file, we could prevent a couple hundred lines of code from loading on non-search pages.

cpliakas’s picture

cpliakas commented
Component: Contrib » Code
Status: Active » Needs review
StatusFileSize
new facetapi-1376586-2.patch5.81 KB

We also had to omit hook_facetapi_facet_info(). We might be able to add this hook to the list if we cache the return value.

cpliakas’s picture

cpliakas commented
StatusFileSize
new facetapi-1376586-3.patch9.87 KB

Added facetapi.facetapi.inc file to patch.

cpliakas’s picture

cpliakas commented
Status: Needs review » Fixed

Committed at http://drupalcode.org/project/facetapi.git/commit/a3f046e.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.