Posted by stewart.adam on December 20, 2011 at 6:30am
| Project: | Invite Discount |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
This patch corrects the following issues:
- $may_cache is no longer used in hook_menu()
- the $form_id, $form_values parameters have gone away in favour of $form and &$form_state (the data previously in $form_values is now stored $form_state['values'])
- The submit form has been changed to use a submit button instead of system_settings_form() as the module has its own submit function that sets the variables
Misc. other coding style changes as per recommendations by the Code Review module
- Eliminated use of tabs in favour of two spaces
- Empty lines should not be indented
Comments
#1
#2
Thanks for this. There's one typo, an extra '$' I found in your patch:
+ else if ($$form_state['values']['reset'] == $form_state['values']['op'])#3
Oops, sorry about that!