Don't insert smileys in code tags
Wim Leers - April 19, 2007 - 18:28
| Project: | Smileys |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
This is the desired and expected behaviour, but currently not being applied by smileys.module.
i.e.:
[code] :) [/code]
and
[notag] :) [/notag]
and
<code> :)
#1
(I accidentally hit the submit button too early...)
In all of these examples (note that the last example isn't rendered correctly either by drupal.org's filter... ironic), smileys.module's filter incorrectly inserts smileys.
We'd either have to use lookahead/lookbehind regexps, or split the text to only apply the smileys filter on the parts that are not inside of any of the tags listed above.
#2
Any news about this? :)
#3
This would be some regular expressions magic. I'm too busy this summers, can you take on it? :D
#4
Fixed in DRUPAL-6--1-0-ALPHA5. Only for <code> and <pre> tags.
#5
I think we can make this an option. Since I feel loading performance being hit when loading like 100+ smileys (which is very possible in fun communities).
#6
Cleaning up the issue queue.