Automatically reverse region order in rows on rtl languages

Does it really make sense to hard-code this behaviour? While I have little experience with RTL websites, I find it hard to believe that it's a universal rule to reverse order of all content.

The patch fails several code style tests:

Indentation is wrong
Missing braces on an if/else clause
(very very minor) missing a . at the end of the comment.

You may need to read about the Drupal coding style guidelines if you intend to continue contributing patches. The patch seems perfectly reasonable to me, if it can be improved to match code style, so I think the community would be well-served if you did this.

Also, retitling for clarity. The original title does not reflect what this patch accurately does, and created a misperception that skewed Letharion's review.

If you two say so :)
My in-experience in the RTL area probably made me confused.

+ if ($language->direction == 1) {

Is there a constant or something we can use so we don't compare this to the number 1? It looks like it should be LANGUAGE_RTL -- and that's much better than comparing against a number.

Compare with RTL constant instead of 1.

Should code that uses the $language global at some point be converted to use the page manager language context in the future?

I don't think there is a way to feed the layout a language context meaningfully. The global language is probably just fine.

It occurs to me that this probably should be optional (on by default for new layouts, off for existing layouts) in the canvas settings. It is entirely possible that there are people who have already set up their sites for RTL languages that would suddenly have their layouts flip on them. That would be unfortunate for them!

@merlin The language functionality I refer to is this one #1301908: Language support for Page Manager.

#10 does not adress the concerns in #8, and as far as I can tell looks no different from #5, so I set this back to needs work.

Drupal 7 is no longer supported, closing.