select all + modify taxonomy terms + taxonomy with depth filter produces error [#1378094]

Under the following conditions:

A VBO display containing an exposed 'taxonomy with depth' filter
selecting all records across all pages
attempting the 'modify taxonomy terms' action

The resulting page to configure the taxonomy modification shows an error, stating 'The selected nodes are not associated with any vocabulary. Please select other nodes and try again.'

After tracing this back through the module's function calls, it appears that the _views_bulk_operations_get_selection_full() function is returning an empty set of results.

Other actions, like 'modify node fields' or 'change the author of a post' do not display similar behavior in terms of error messages, but will operate over a batch of 0 items, which indicates the _views_bulk_operations_get_selection_full() is returning empty results in those contexts as well.

Comment	File	Size	Author
#3	views_get_view-instead-of-clone_view-1378094-3.patch	630 bytes	dsayswhat

Comments

Comment #1

bojanz commented 21 December 2011 at 11:26

How recent is your VBO -dev? The select all behavior saw some work a week ago.

Comment #2

dsayswhat commented 21 December 2011 at 19:54

Hi there - I assume you're referring to #1280776: Bring back "select all" checkbox. I updated to the newest dev yesterday (12/20), after reading that and several other threads which might have been related.

I've been looking into the calls that are being made via the views API to see what I can figure out, but I haven't gotten very far yet. If you've got any pointers that might help, I'd be happy to look further...but the cloned version of the view returns nothing.

Comment #3

dsayswhat commented 21 December 2011 at 22:31

Status	File	Size
new	views_get_view-instead-of-clone_view-1378094-3.patch	630 bytes

It looks as if the configuration of $view_copy in _views_bulk_operations_get_selection_full() was wonky somehow. When I replaced the call to $view->clone_view() with views_get_view($view->name), all seemed to be well.

It's only a one-line change, but the patch is attached below.

Is there a reason to avoid views_get_view in this case? Should we be looking for why the cloned version isn't doing the job?