Because the JS code from the Fancybox JS library actually has examples, etc, then the actual fancybox files in a "fancybox" subfolder, the library inclusion breaks in this module. This is a pain for folks including fancybox in a drush make script for install profiles.

Attached is a patch to make the library inclusion work again for the 1.3.3 version of the fancybox JS library.

CommentFileSizeAuthor
#3 fancybox_library_sub_folder-1378104-3.patch1.14 KBAnonymous (not verified)
#1 fancybox_library_sub_folder-1378104-1.patch653 bytesAnonymous (not verified)
fancybox_library_sub_folder.patch1011 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new fancybox_library_sub_folder-1378104-1.patch653 bytes

Rerolled against latest dev release.

bas.hr’s picture

bas.hr commented

can you also update README.txt so it is in sync with this change?

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new fancybox_library_sub_folder-1378104-3.patch1.14 KB

Got it, updated the readme file as well.

bas.hr’s picture

bas.hr commented
Status: Active » Fixed

DIRECTORY_SEPARATOR shouldn't be used for URL because on windows its \. Someone already proposed patch so I modified yours.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.