Error Notices in PHP 5.2.* [#1378364]

Full error codes I'm getting:

Notice: Use of undefined constant FILTER_SANITIZE_FULL_SPECIAL_CHARS - assumed 'FILTER_SANITIZE_FULL_SPECIAL_CHARS' in Prometheus::register() (line 77 of D:\Web_Public\Prometheus\sites\all\modules\prometheus\classes\prometheus.class.php).

Notice: Undefined index: DEFAULTS in Prometheus::register() (line 77 of D:\Web_Public\Prometheus\sites\all\modules\prometheus\classes\prometheus.class.php).

Notice: Undefined index: paths in Prometheus::register_class() (line 209 of D:\Web_Public\Prometheus\sites\all\modules\prometheus\classes\prometheus.class.php).

Comment	File	Size	Author
#3	prometheus-error_notices-1378364-3.patch	2.11 KB	Akaoni
#1	prometheus-undefined_const_notice-1378364-1.patch	778 bytes	Akaoni

Comments

Status	File	Size
new	prometheus-undefined_const_notice-1378364-1.patch	778 bytes

Comment #2

Akaoni commented 21 December 2011 at 04:09

Status:

Active

» Needs review

CNR

Comment #2.0

Akaoni commented 21 December 2011 at 23:11

Issue summary:

View changes

Added more notices.

Status	File	Size
new	prometheus-error_notices-1378364-3.patch	2.11 KB

Comment #4

slobo commented 17 January 2012 at 00:56

What will happen on PHP <5.3.3 if someone uses FILTER_SANITIZE_FULL_SPECIAL_CHARS in their input sanitization? Would it be a graceful failure / would the user be notified that the module won't perform as expected?
Perhaps it is better not to include FILTER_SANITIZE_FULL_SPECIAL_CHARS as the available mapping option in that case, or have filter_full_special_chars revert to filter_special_chars, but that would need to be documented.

The other part of the patch looks good.