YSlow reports that lightbox2/js/lightbox.js is not compressed. I have Drupal 7 aggregate javascript turned on which if I look in files/js has created compressed files (but doesn't seem to aggregate). Lightbox.js isn't one of these files. I guess this is because line 789 of the module says don't cache. Why?

Comments

yukare’s picture

yukare commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev

Because we had a bug with compression in lightbox.js(this bug is with lightbox, not drupal agregation) , I must test if it still exist or try to fix it, but I was unable to find the exact error when i did this. While working on upgrade (drupal 6 => drupal 7) lightbox.js with compression enabled breaks all javascript( ajax support) on the site.

malc_b’s picture

malc_b commented

On my site, www.suttonbenger.org.uk I've put scripts at the bottom and patched lightbox module to allow lightbox.js to be compressed. It all seems to work, see http://www.suttonbenger.org.uk/gallery/winter-2010

yukare’s picture

yukare commented
Status: Active » Closed (fixed)

Fixed in http://drupalcode.org/project/lightbox2.git/commit/6fe8b87

adrien.nethink’s picture

adrien.nethink commented
Issue summary: View changes

Hum, it seems that a fixed has been released 3 years ago, and still nothing changed in the current version of "Lightbox2" module (7.x-1.0-beta1)..
This is not a huge bug - but, when having a big website with many many users it's better not to have anyone loading the file if this one can be cached ..
Thats it.

Thanks anyway for the work you've done on Lightbox2 Module.