in function quicktabs_export_form()

  // Generate export code
  $code = '$items = array();' ."\n";
  $code .= ctools_export_object('quicktabs', $qt, '');
  $code .= '$items["'. $qt->machine_name .'"] = $quicktabs;' ."\n";
  $code .= 'return $items;';

should be just:

  // Generate export code
  $code = ctools_export_object('quicktabs', $qt, '');

Why:
- views module does the same, it only makes the export code of 1 view, not an array of views.
- array of quicktabs can be generated with ctools bulk_export

CommentFileSizeAuthor
#3 remove_the_items_array_from_export-1379034-3.patch951 bytesbarbi

Comments

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Issue tags: +Novice

.

barbi’s picture

barbi commented
Assigned: Unassigned » barbi
barbi’s picture

barbi commented
Status: Active » Needs review
StatusFileSize
new remove_the_items_array_from_export-1379034-3.patch951 bytes
valthebald’s picture

valthebald
Location Sofia
commented
Status: Needs review » Reviewed & tested by the community
  1. Patch still applies to the latest 7.x-3.x
  2. Output of export form without patch differs from views export format
  3. Output of export form with patch has format similar to views export
  4. I don't know what was the reason for including $items array in export, but patched behavior makes more sense to me, so marking RTBC.
ultimateboy’s picture

ultimateboy commented
Status: Reviewed & tested by the community » Fixed

Thanks. Committed to 7.x-3.x

Automatically closed -- issue fixed for 2 weeks with no activity.