Posted by LordVan on April 20, 2007 at 3:48pm
Jump to:
| Project: | Birthdays |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
no postgres tables are created - and no error is shown either :(
submitted patch for both install file and modules file to work with pgsql as well (added switch -case statements)
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| birthdays_pgsql_fix.patch | 6.79 KB | Ignored: Check issue status. | None | None |
Comments
#1
Thank you very much for that, it really makes our work a lot easier.
I'll review the patch, and commit it as soon as I find the time.
#2
Thank you very much for that, it really makes our work a lot easier, as this was a 'bug' or feature that I wanted to add eventually but my postgres knowledge is nowhere near my mysql-knowledge.
I'll review the patch, and commit it as soon as I find the time.
#3
I just noticed something in my postgresql logs...
there's a query I missed which I will fix later today or something like that ... (no error on the webpage just in the logs ..
the query is in function _birthdays_message() ;)
#4
I've used your patch to patch the dev release. Since this issue there had been many changes, but with the help of the PostgreSQLs documentation and your patch, I had no problems adding pgsql-support.
As far as I can tell (installed and tested it briefly) there are no problems.
Thanks for your work, and good luck with the module.
#5
Automatically closed -- issue fixed for two weeks with no activity.