invalid index in domain_theme.features.inc [#1379182]

I got errors while reverting a feature that included domain_theme configurations.
Php warned me about an invalid index defined at line 102 of the domain_theme.features.inc so i've tried to debug that.
It was about domain_theme_features_rebuild($module), that function loops inside the $defaults array created using domain_features_load() function that i didn't investigate, inside that loop it stores the array values as $themes and then loops inside each $themes storing values as $theme.
Then it creates a $record array that will be passed through drupal_write_record() after populating it with the same keys and values of $theme.
Anyway, in my situation, $themes was holding a nested array with its same key so i fixed looping inside $themes[$key] instead of $themes, that way i could really access the keys and values to be saved as the $record ones too.
So, basically, line 96 becomes foreach ($themes[$key] as $theme) { instead of foreach ($themes as $theme) { .
Take a look at this, please...
Thanks,
Da.

Comment	File	Size	Author
#5	1379182-domain-theme-features.patch	602 bytes	agentrickard

Comments

Comment #1

agentrickard

he/him

English

Georgia (US)

commented 22 December 2011 at 14:19

Status:

Active

» Postponed (maintainer needs more info)

This is impossible to read and debug.

Please state the problem more clearly, and, if possible, attach the feature output.

Comment #2

planctus commented 22 December 2011 at 16:10

/**
 * Implements hook_features_rebuild().
 */
function domain_theme_features_rebuild($module) {
  if ($defaults = domain_features_load($module, 'domain_theme_default_themes', TRUE)) {
    // Wipe the old records.
    db_delete('domain_theme')
      ->execute();
    foreach ($defaults as $key => $themes) {
      $domain_id = domain_load_domain_id($key);
      if (!$domain_id) {
        continue;
      }
      // Save the new records.
      if (empty($themes)) {
        continue;
      }
      foreach ($themes[$key] as $theme) {
        $record = array(
          'domain_id' => $domain_id,
          'theme' => $theme['theme'],
          'settings' => serialize($theme['settings']),
          'status' => $theme['status'],
          'filepath' => $theme['filepath'],
        );
        drupal_write_record('domain_theme', $record);
      }
    }
  }
}

This is the function i was speaking about, this way it is working. I've made changes here:
foreach ($themes[$key] as $theme) {
it was
foreach ($themes as $theme) {

My feature's output about domain_theme is:

/**
 * Implements hook_domain_theme_default_themes().
 */
function domains_domain_theme_default_themes() {
$domain_themes = array();
  $domain_themes['firenze_institutfrancais_n3'] = array(
  'firenze_institutfrancais_n3' => array(
    'pixture_reloaded' => array(
      'theme' => 'pixture_reloaded',
      'settings' => NULL,
      'status' => '1',
      'filepath' => '',
    ),
  ),
);
  $domain_themes['institutfrancais_n3'] = array();
  $domain_themes['milano_institutfrancais_n3'] = array(
  'milano_institutfrancais_n3' => array(
    'danland' => array(
      'theme' => 'danland',
      'settings' => NULL,
      'status' => '1',
      'filepath' => '',
    ),
  ),
);
  $domain_themes['napoli_institutfrancais_n3'] = array(
  'napoli_institutfrancais_n3' => array(
    'seven' => array(
      'theme' => 'seven',
      'settings' => NULL,
      'status' => '1',
      'filepath' => '',
    ),
  ),
);
  $domain_themes['palermo_institutfrancais_n3'] = array(
  'palermo_institutfrancais_n3' => array(
    'garland' => array(
      'theme' => 'garland',
      'settings' => NULL,
      'status' => '1',
      'filepath' => '',
    ),
  ),
);

return $domain_themes;
}