Couple of errors in the PostgreSQL table creation script
swmerrill - April 20, 2007 - 16:18
| Project: | Outline |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
The table outline_nodes does not get created when Outline is installed for Postgresql. There's a missing right parenthesis on the line for Primary key. To close the open parenthesis in the CREATE TABLES statement the code should read:
PRIMARY KEY (nid))
rather than
PRIMARY KEY (nid)
Thanks.
#1
Besides the already mentioned missing parenthesis, there are two other problems with the PostgreSQL install script:
- The sequence 'volume_id_seq' is not created, and Drupal expects it to be there (and with that name - normally, I'd just change outline_volume.volume_id from int_unsigned to serial, but Drupal explicitly wants to use volume_id_seq)
- The 'weight' column is not created
The patch is really trivial:
--- drupal5-outline-1.0.orig/outline.install
+++ drupal5-outline-1.0/outline.install
@@ -39,13 +39,15 @@
child_type varchar(32) NOT NULL default '',
toc_depth smallint NOT NULL default '1',
PRIMARY KEY (nid)
- ");
+ )");
db_query("CREATE INDEX {outline_nodes}_volume_id_idx ON {outline_nodes} (volume_id)");
db_query("CREATE INDEX {outline_nodes}_parent_idx ON {outline_nodes} (parent)");
db_query("CREATE INDEX {outline_nodes}_child_type_idx ON {outline_nodes} (substr (child_type, 1, 4))");
+ db_query("CREATE SEQUENCE volume_id_seq");
db_query("CREATE TABLE {outline_volume} (
volume_id int_unsigned NOT NULL default '0',
title varchar(128) NOT NULL default '',
+ weight smallint NOT NULL default '0',
default_toc_depth smallint NOT NULL default '1',
default_child_type varchar(32) NOT NULL default '',
PRIMARY KEY (volume_id),
#2
no patch attached.