Export Button, make it styleable with CSS

+1 ,
an alternative is to generate a link, like the following modules do:
- print: 'print this page', 'send this page'
- nodereference_url: 'create node'
They support a link with only title, or include an icon, too.

I've made this patch to solve this issue for version 7.x-3.x-dev.

After you apply this patch the export links will only contain the Attach text, not an image, and the new css file will provide the proper background and will hide the Attach text from the link. Also i added a shared option which lets you select whether to have the image or just simple text link (basically the link gets a different class).

changed status.

Hi Bálint, I tested your patch, I like it, and I have the following comments:

- there is no need to put the css-file in a separate directory.

- the new setting is now under the FORMAT section. IMO this sets the file settings; it would be better to put it under DATA EXPORT SETTINGS, in the list "Path:, Attach to:, Batched export:"

- the default layout is now out-of-style. It would be nice if one could choose for one of both standard options:
-- action-link (like admin/content/node )
-- inline-link (like print moduleprint module )
See attached printscreen.

Sorry for the time it took me to get back to this.

I updated my patch to the latest dev, and reworked it according to your feedback, except your last point.

Im not sure how i could change the html structure of the feed_icon part of the template around the links, without overwriting the whole views-view.tpl template which is in the views module.

I attached the updated patch.

We export our views with Features. When I export the vies after applying the patch #5, I don't have the attribute 'link_only' so I have an error when reimporting my views... Would it be possible to have a default behavior to show only icons if the attribute is not found ?

In plugins/views_data_export_plugin_style_export.inc, change the line to this:

   'link_only' => isset($this->display->display_options['link_only']) ? $this->display->display_options['link_only'] : FALSE;

5: styleable_export_links-1379672-5.patch queued for re-testing.

I don't understand why there is a hard-coded image associated by default anyway ... ??? If a person wants an image, they can css a background image.

I've rerolled the patch for 7.x-3.0-beta8.

I get some errors when trying to apply the #12 patch. Can you have a look what I am doing wrong? See attachment for my terminal output.

Thanks.

I'm not familiar enough with git patching to help you but it did work for me using 'patch -p1 < filename' against the 7.x-3.x branch.

No errors with the patch that I can see.

Here is the exact patch from #12 rerolled to apply cleanly to latest dev version.

Also I'm guessing this is no longer assigned to nagy.balint since that was 3 years ago, so unassigning.

Patch works fine for me.
I had a quick look over the code and there are no obvious coding standards issues but I haven't reviewed it technically.

The only issue I ran into after applying this patch was an undefined index error when looking at the view. Basically the "link only" setting isn't set until after explicitly setting it and re-saving the view.

Notice: Undefined index: link_only in attach_to() (line 176 of /export/www/html/sites/all/modules/contrib/views_data_export/plugins/views_data_export_plugin_style_export.inc).

Notice: Undefined property: views_display::$handler in execute() (line 1134 of /export/www/html/sites/all/modules/contrib/views/includes/view.inc).

When you attach two (or more) views_data_export displays to one page display, it's impossible to make a distinction between them (except by the title attribute on the XLS-icon). So, I've expanded the patch from #16 to make it possible to add extra CSS classes to the link which allows to distinct the links or simply allows to add styling to them.
I also fixed the issue Sborsody described.

Hello,

In release 7.x-3.0-beta8, the feed icon link is fully themable as indicated in theme/views_data_export.theme.inc file (lines 22 to 50).

For example, to change all XLS export icon:

function MYTHEME_views_data_export_feed_icon__xls($variables) {
  extract($variables, EXTR_SKIP);
  $image_path = '/path/to/the/xls/icon.png'; // INDICATE HERE THE PATH TO THE IMAGE FILE
  $image_class = 'icon-xls'; // INDICATE HERE THE CSS CLASS(ES) TO PUT ON THE IMAGE
  $url_options = array('html' => TRUE);
  if ($query) {
    $url_options['query'] = $query;
  }
  $image = theme('image', array('path' => $image_path, 'alt' => $text, 'title' => $text, 'attributes' => array('class' => $image_class))); // FUNCTION ALTERED TO ADD CUSTOM CSS CLASS TO THE IMAGE
  return l($image, $url, $url_options);
}

in which $image_path and $image_class variables were added and $image variable is altered to use added variables.

The last patch in the related issue that I added does the same thing as this patch, but approaches it in another way...perhaps a simpler way? Please check it out.

I prefer this patch and approach to the one in: #2261167: Option for non-image link display, I wonder if we couldn't just reduce it down to sending some classes to the theme function though, singling out a specific option for making the link use the 'default icon' or something, which just adds a class to the set of classes to add.

Happy to work on this in bit, unless someone else wants to pick it up.

Hey @Steven Jones--one of the things I liked about the other patch is that the alt text (which became the text displayed within the button/link) and the class options were both in the same location, so a site builder would only need to go to one place to do everything related to this. If you work on this patch, could you try to incorporate that same idea? Last time I tried this patch, it seemed less user-friendly in that way, so I continued to work on the other patch.

Any update on this one - seems to have ground to a halt, likewise for #2261167: Option for non-image link display

Patch #19 works for me.

Patch #19 works for me. It would be nice to have it committed.

CSS classes must be added as array elements, not as a concatenated string.

  $url_options['attributes']['class'] = [$class_name];

  if ($css_class_icon) {
    $url_options['attributes']['class'][] = $css_class_icon;
  }

Hi,

I am assigning this issue to me. Let me try once to fix that. I will update you soon as I can fix it or not.

Thanks

Hello @legato, I tried to apply both files of your patch but both are not applying to me.
Getting this error.

Lenovo@LAPTOP-PDE747K8 MINGW64 /c/xampp/htdocs/drupal-9/web/modules/contrib/views_data_export-1379672 (1379672-export-button-make)
$git apply -v views_data_export-styleable_export_links-1379672_0.patch
error: corrupt patch at line 120

Lenovo@LAPTOP-PDE747K8 MINGW64 /c/xampp/htdocs/drupal-9/web/modules/contrib/views_data_export-1379672 (1379672-export-button-make)
$ git apply -v views_data_export-styleable_export_links-1379672-19.patch
Checking patch plugins/views_data_export_plugin_display_export.inc...
Checking patch plugins/views_data_export_plugin_style_export.inc...
Checking patch theme/views_data_export.theme.inc...
error: while searching for:
 */
function theme_views_data_export_feed_icon($variables) {
  extract($variables, EXTR_SKIP);
  $url_options = array('html' => TRUE);
  if ($query) {
    $url_options['query'] = $query;
  }
  $image = theme('image', array('path' => $image_path, 'alt' => $text, 'title' => $text));
  return l($image, $url, $url_options);
}

/**

error: patch failed: theme/views_data_export.theme.inc:41
error: theme/views_data_export.theme.inc: patch does not apply
Checking patch views_data_export.css...
Checking patch views_data_export.module...
Checking patch views_data_export.views.inc...

Can you please suggest how to fix that issue?
Thanks

Need work

+1 for this feature request

Seems this module provides templating for the export icon for some time now, so I assume this has been solved.

The patch provides detailed changes, and this thread contains a robust discussion about why those changes are necessary.

@ant1, Your comment does not add to the discussion, or provide any response to the proposal.

Resetting to Needs Review.

Why doesn't provide a better button? or a button like action?
I don't want override button inside admin theme.
Thank you

Moving back to needs work due to...

1. The issue summary describing the problem but not clearing laying out a proposed resolution.
2. This issue has a visible patch (that doesn't apply to HEAD) -- patch workflow is antiquated and will not run automated tests anymore.
3. This issue having 2 forks (which are hidden by default) -- both of which go different directions than the patch.

All in all, I don't think this can be "needs review". There needs to be a written-down plan and one up to date merge request to be eligible for needing review IMHO.

That all said something definitely needs to be done here. The tap area for the current out of the box experience is too small to pass accessibility audits, so tagging with accessibility.