Active
Project:
Menu Minipanels
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Dec 2011 at 12:31 UTC
Updated:
27 Jan 2012 at 02:28 UTC
Jump to comment: Most recent file
I've started with a refactoring of the module to allow for pluggable libraries (where libraryspecific settings and code will be stored in submodules), because I need to have pluggable libraries for a project I'm working on, and qTip 1 is about to become obsolete.
Is there someone else who is interested in working on this, and should this (quite major) change be part of 7.x-1-dev or should we perhaps create a 7.x-2-dev branch where we also can start implementing other big changes to the module (e.g. where HTML should be output, bottom of page or, more semantically, in the menu li:s)?
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | menu-block-fix-for-plugg-lib-2.patch | 1.89 KB | FreddieK |
| #4 | menu-block-fix-for-plugg-lib.patch | 1.88 KB | FreddieK |
| #3 | menu-minipanels-pluggable-libraries-1380058-5.patch | 122.22 KB | FreddieK |
| #2 | menu-minipanels-pluggable-libraries-1380058-5.patch | 107.98 KB | FreddieK |
| #1 | menu-minipanels-pluggable-libraries-1380058-4.patch | 107.99 KB | FreddieK |
Comments
Comment #1
FreddieK commentedSo, this is a work in progress, but I've begun restructuring the code and adding library support in submodules. Quite much code is being duplicated in the library submodules right now, much of it should probably be moved out to the menu_minipanels module (like menu_minipanels_get_lib_path has been).
For now, installation and drush files has been removed. Qtip2 implementation is working as a proof of concept, but without any settings.
Legacy paths for libaries not supported, so you must use Libraries api or sites/all/libraries for the files. Qtip should be located under libraries/qtip/jquery.qtip-1.0.0-rc3.min and Qtip2 under libraries/qtip2/jquery.qtip.min.js and libraries/qtip2/jquery.qtip.min.css as of now.
Please feel free to comment and improve upon it.
Comment #2
FreddieK commentedTesting new version of patch, since the last one fails in some environments.
Comment #3
FreddieK commentedNew test.
Comment #4
FreddieK commentedApplying patch for Menu Minipanels to support all menus, fixed to work with this version.
( http://drupal.org/node/1199790#comment-5229750 )
Comment #5
FreddieK commentedFixed version
Comment #6
damienmckennaJust to mention it, once we get this functionality working I'll build a v2 branch out of it, I want to keep v1 focused on just qTip v1. Also, @FreddieK, thanks for your work on this so far.
Comment #7
damienmckennaPlease re-roll your patch against the latest version and before to update your local copy with the latest code, your patch inadvertently reverts some recent changes and thus is hard to properly review. Thanks.