Posted by drzraf on December 22, 2011 at 12:55pm
2 followers
Jump to:
| Project: | Inline |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
See http://en.wikipedia.org/wiki/Comparison_of_web_browsers#Image_format_sup...
the attached patch won't hurt.
not sure it'll applies but the modification is obvious
Ideally $file->type == 'image' should imply rendering, then it's up to the browser to handle the <img>
according to the mime type it supports.
| Attachment | Size |
|---|---|
| display-bmp-svg.patch | 809 bytes |
Comments
#1
#2
BMP is too-damn-huge and SVG is poorly supported by browsers, so i think it's bad idea.
#3
I don't think there is room for arbitrary exclusion here.
If the browser does not support SVG it WILL offer to download the file or won't display it.
But not offering support for SVG by default is not a good choice, at least because some (very common) browsers DOES support (a large subset) of SVG.
BMP is actually an image format, please see
grep image/ /etc/mime.types#4
I'm agree now. After all it worths applying a patch.