Restrict viewfields to certain views

I like it. I kept meaning to implement something like this.

One thought: should this be a field or a widget setting? Officially, the CCK "way" is to have the field define it's restrictions. So each viewfield would say which views it accepts.

I don't know that I love that idea. Perhaps we should implement both. The field defines an outer set, and the widget can remove items with that as well.

Thoughts anyone?

Yeah, the CCK way is that the data definition of the field (which kind of data, which allowsd values...) are field stuff (vs field instance). That's 'only' a convention (sometimes with good technical reasons : it's best to know what you can expect to find in the db columns). But maybe viewfield is an edge case after all...

The 'data' viewfield stores are a view and an 'arguments' string.

What about that :
- Field level : define what views are eligible to use with the field - if only one, then the widget will not display the views selector.
This 'defines' the field. You need another view ? Then you want another field.
- Field instance level :
Using CCK's generic 'default value' handling, you can define a default value for both the view (amongst eligible views) and the arguments (cck's generic default value handling)
Plus viefield_widget_settings defines a checkbox saying 'stick to the default value', and then the widget displays nothing - no views selector, no arguments textfield.

This is a nice patch that will make the DrupalEd Distribution just that much easier to use. We'll be able to remove the caveat here: http://drupaled.alphabetademo.org/?q=wiki/creating-groups by pre-selecting only the views that work within a Course.

I tested out the patch and it works great. Will there be a need for an update_ function in the module to clean up any CCK types that include pre-existing Viewfields?

The only problem with this, in our situation, is that we may add new Views that would work within a Course, so we'll have to update the settings for the fields too. If we had the option of somehow specifying a dynamic subset of Views (either with PHP or a regex or ??? -- in our case, we're using a naming convention for the Views -- they all start with "group_"), we'd be done once the new View was created.

Thanks for this,

Marc

Committed. Thanks to everyone who worked on this.

One small change in the committed version: the "force default" checkbox is now on the widget settings section. Thus, if people want to use other widgets later the "hide all" option is not mandatory. Also, users with 'administer nodes' get the full form on all pages.

I tried running this patch (restricted_views_1.patch) on the last release viewfield-5.x-1.2.tar.gz
and it started giving errors. The patch was done with patch.exe and no errors were reported.

Any ideas? Dang I need this feature

goose2000 - This is probably due to legacy data, as Crell mentioned in comment #7. I haven't yet gotten around to reproducing the problem, but I saw some warnings the first time I looked at a previously existing View with a Viewfield in it. I think it got cleared up after saving the View again, though...

Can you reproduce this by rolling your system & data back to the previous version of Viewfield and then updating again?

Whoops, I think I said "View" where I meant "node" a few times in that previous comment... But you probably got the gist of it.

Hey, I'll be looking at it again today, try to reproduce and document too.
I think were saying 'previously existing NODE with a Viewfield in it'

BTW, is there a patched file you could send, to compare with?

If you go here: http://cvs.drupal.org/viewcvs/drupal/contributions/modules/viewfield/vie...

You can probably try the latest version that Mark has checked in...

Wow, a hidden 'force view' and tokens too, cool. Were there any DB changes? Like to hold the 'force view' or other default options? I did download the latest from cvs and looks to work, but won't save my 'force view' check box. ?

Ohhh this will be neat.

Hi, I've been testing this version:

viewfield.module,v 1.3.2.8 2007/05/29 02:50:49

I get no errors, and seems right except, when I choose the force mode:

Force default
If checked, the user will not be able to change anything about the view at all. It will not even be shown on the edit node page. The default value will be used instead.

The setting does not save. Is there some DB change to hold this info? All other settings for the field save fine.

Any idea when there will be a new release to include this feature? It would be VERY useful to me but I'm not too keen on switching to the HEAD. Even a 5.x-1.3-dev semi-stable release would be better than HEAD.

hi, i'm getting this errors:

# warning: array_flip() [function.array-flip]: The argument should be an array in ..\modules\cck\viewfield\viewfield.module on line 216.

# warning: in_array() [function.in-array]: Wrong datatype for second argument in ..\all\modules\cck\viewfield\viewfield.module on line 219.

line 216: $allowed_views = array_flip($field['widget']['allowed_views']);
line 219: if (! (0 === $key || in_array($key, $allowed_views))) {

this warnings appear when creating the field, and in the manage fields page when a view field is listed.
the patch works ok eventhough i get this warnings. i have one warning as the first descrved and LOTS of the second descrived. any idea?

my viewfield version: 5.x-1.2