ecard/includes/email.card.inc has:
t('Your E-Card was send.');
and
t('A copy of your E-Card was send to you.');
Proper tense is 'sent'.

ecard/theme/ecard_field.tpl.php fails to have 'Hey' and 'Regards' as translatable strings:
<div class="name-to">Hey <?php print $variables['ecard']->name_to ?>,</div>
<div class="content">Regards <?php print $variables['ecard']->name_from ?></div>

They should be included in a t() function for proper multilingual usage:
<div class="name-to"><?php print t('Hey') ?> <?php print $variables['ecard']->name_to ?>,<br>
<div class="content"><br><?php print t('Regards') ?>, <?php print $variables['ecard']->name_from ?>

CommentFileSizeAuthor
#3 1380428-3.patch35.43 KBstella
#2 ecard-strings.patch2.29 KBkars-t

Comments

rooby’s picture

rooby commented

Can you make a patch of the changes you mention?

kars-t’s picture

kars-t commented
Status: Active » Needs review
StatusFileSize
new ecard-strings.patch2.29 KB

Hi

did make a patch because I currently can't test it.

The template is ugly like this so I put the t() strings in the function that calls the template. And I fixed the typos. Please test it.

stella’s picture

stella commented
StatusFileSize
new 1380428-3.patch35.43 KB

Rerolled patch attached. The above patch didn't call the t() function correctly. The second argument needs to be an array.

The attached patch contains a fix for that, but also the following changes:

  • Changed "receiver" to "recipient" as that reads better
  • Fixed typos in spellings of "receive", "friends" and a few others I found.
  • Now, maybe you won't approve of this change, but I really didn't like "E-Card" and changed that to "Ecard" or "ecard" as appropriate. It's like the way no one uses "E-mail" any more, but rather "Email".
kars-t’s picture

kars-t commented
Status: Needs review » Fixed

Much much nicer! Added the patch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.