I'll start working on a patch, but once the other release blockers are in we should commit a cleanup.

There's a handy review service that combines several different automated scripts (coder, coder_tough_love, drupalcs, and pareview.sh).
It still has a number of false positives, but it is useful.

http://ventral.org/pareview/httpgitdrupalorgprojectfeaturesgit-7x-1x

CommentFileSizeAuthor
#2 features-1380662-2.patch9.02 KBtim.plunkett

Comments

febbraro’s picture

febbraro commented

Great, thanks for this. I agree whole-heartedly.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: tim.plunkett » Unassigned
Status: Postponed » Needs work
StatusFileSize
new features-1380662-2.patch9.02 KB

We're getting close now, we should get this going.
I started on it, but quickly ran out of steam.

mpotter’s picture

mpotter commented

Wow, I ran out of steam too. I just don't care about line lengths > 80 and stuff like that.

I did fix some of the check_plain reports and I did incorporate the work that tim.plunkett did in his patch. Other people are welcome to continue working on this and submitting further patches.

Current commit to d57bee4, but still more work needed. Be sure to work with the latest dev version if you want credit for your patch work.

mpotter’s picture

mpotter commented
Issue tags: -D7 stable release blocker
mgifford’s picture

mgifford
he/him
Primary language English
commented

@mpotter - so @tim's changes got in? You're just looking for more contributors to clean up the remaining formatting issues?

mpotter’s picture

mpotter commented

@mgifford: Yes! Definitely looking for more contributors to help with the cleanup. But you might want to wait till the 1.1 UI branch merge to avoid remaking a bunch of patches that will change.

mgifford’s picture

mgifford
he/him
Primary language English
commented

Excellent. Can you put up a note here when it's safe to put up a new patch after the UI changes?

hefox’s picture

hefox commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Issue summary: View changes
Status: Needs work » Active

I think this is still relevant though some patches were added to to fix up some instances to my memory

  • mpotter committed d57bee4 on 8.x-3.x 
    Issue #1380662 by tim.plunkett: Clean up coding standards.