Closed (duplicate)
Project:
Media: Vimeo
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
23 Dec 2011 at 09:50 UTC
Updated:
26 Mar 2012 at 16:35 UTC
Jump to comment: Most recent file
Comments
Comment #1
goz commentedHere is the patch to add options
Comment #2
jhubley commentedThis patch works. Thanks, it was helpful.
Comment #3
rokrAlthough i had some problems applying the patch it now works for me. It would be great to see this committed and maybe more options which i remember from original emfield/vimeo module (color, maybe player controls).
Thanks for the patch, rokr
Comment #4
KoCo commentedOké first of all, former patch (#1) works and if it can be committed, go ahead.
Attached patch also adds the option for color choosing and uses Drupal's color picker.
This probably will not work everywhere and always, so please test.
Also coding isn't actually how it should be, but it's a start.
K
p.s. I'm currently working on a project without any version control, so I adapted former patch. Please forgive me ;-)
Comment #5
KoCo commentedSorry added the wrong file
Comment #6
drewish commentedSeems like there's some overlap with #1443092: Add more video display settings, switch to universal player.. I think both add a lot of code for something that should be pretty simple. I think we should find a simpler way to handle the settings. Those accessor functions just seem noisy. Why not simply expose an array of settings?
Comment #7
drewish commentedi can't get this patch to apply at all. It keeps reporting it as "patch: **** malformed patch at line 30" i tried deleting the first few chunks to see if there was something specific to those but it just failed at later line numbers.
Comment #8
drewish commentedJust going to use the other patch as a starting point since it applies.