When using a PHP for access condition to displays with the same path, Master display is returned instead of the granted access display.
Steps to reproduce:

  • 1. Create a View (e.g. showme on /showme)
  • 2. Add a footer Global Text "FooterMaster"
  • 3. Override the footer editing it and selecting For "This Page (override)" with text "Footer1"
  • 4. Add a Page
  • 5. Set the path as the same view (/showme)
  • 6. Override the footer of the second page editing it and selecting For "This Page (override)" with text
    "Footer2"

    • At this point Views is ment to show the first display that grants access
    http://drupal.org/node/278651#comment-908464

  • 7. Change access in the first page to All displays (except overridden) to PHP, then set "return FALSE"
  • 8. Change access in the first page to This page (override) to PHP, then set "return TRUE"
  • 9. Open /showme and check that footer is "Footer1"
  • 10.Change access in the first page to This page (override) to PHP, then set "return FALSE"
  • 11.Change access in the second page to This page (override) to PHP, then set "return TRUE"
  • 12 Open /showme and check that footer is FooterMaster (should be Footer2)

If you use Roles Access instead of PHP, it works as intended (e.g. set All displays to role Admin, then override page 2 and set role Anonymous and it shows "Footer2")

CommentFileSizeAuthor
#1 views_php-access_fix-1381562.patch1.58 KBmarco.abiuso.questar

Comments

marco.abiuso.questar’s picture

marco.abiuso.questar commented
Status: Active » Needs review
StatusFileSize
new views_php-access_fix-1381562.patch1.58 KB

This issue can be renamed as:
views_php_access only gives access to the first display, otherwise shows default display (if any of the displays has access).

The problem was due to the fact that the checks are done on the wrong display id, i.e. $this->view->current_display instead of $this->display->id ($this is the current view object).

At the view access checking stage, the current_display variable is always 'default', so, even if the checks are run on the correct display, only the default display results accessible (the display id serves only for naming a runtime generated access function containing the custom PHP)

I'm attaching a patch.

P.S. I had to dive into views module internal workings to get the solution: not a funny task, for a so small bug ;-)

liquidcms’s picture

liquidcms commented
Status: Needs review » Needs work

perhaps a different issue; but as far as i can tell php access control does not work.

my simple function:

return false;

view is still visible.

turtletrail’s picture

turtletrail commented

confirm the issue.

if view has multiple displays, it seems that the PHP access works only for the first display it is used one.
The rest of the displays are shown/hidden based on the same condition (from first PHP access definition).

turtletrail’s picture

turtletrail commented

by the way, views_php-access_fix-1381562.patch
worked for me

casey’s picture

casey commented
Issue summary: View changes
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 14637c2 on 7.x-1.x, 7.x-2.x by casey: 
    Issue #1381562 by marco.abiuso.questar: Access Views PHP Plugin make...