The create new ad link has disappeared on my setup. I've checked permissions and everything is good on that end. Even user1 doesn't see the link. I was running 3.0-rc1, and I tried upgrading to 3.x-dev but that didn't have any effect.

The link was there. My users have been posting ads for a couple of weeks now. This morning I got an email from a user asking how to add an ad and that's when I discovered the link wasn't there anymore.

Comments

fgm’s picture

Status: Active » Postponed (maintainer needs more info)

This probably means that something else changed on the site: did you recently install, upgrade, reconfigure, or remove some other module ?

In addition, to which link are you referring ? On which page or block did it use to be ?

pitxels’s picture

same problem here

fgm’s picture

Same question as previous user: cannot reproduce the problem, please provide steps to reproduce it on a clean install with just core and Classified Ads, otherwise I cannot help.

fdg123’s picture

Version: 6.x-3.x-dev » 6.x-3.0-rc2
Component: User interface » Code
Category: support » bug
Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new400.18 KB

The create new ad link has disappeared on my site also. It happened when I upgraded to 6.x-3.0 rc-2. I checked permissions etc. and everything is fine except I have NO create new ad link. We didn't notice it until recently because we get very few classified ad users posting ads on our site. Running drupal core 6.24, linux, apache, php. A pretty normal set-up. The error can be seen on my website at: http://www.vending-la.com/classified
Also attached screenshot.
Hope someone can help.
Frank

fgm’s picture

Status: Active » Postponed (maintainer needs more info)

Can you reproduce the system on a fresh install ? I just did a fresh install, and the link is indeed there, Or provide me with detailed steps to reproduce ? Alternatively, contact me using my contact form so you can send my a dump of your DB with that problem and I can look at why this appears in your case.

(nice theme, BTW)

fgm’s picture

StatusFileSize
new1.91 KB

OK. I think I managed to reproduce a situation where it happens. Can you check on your site ?

  • clear cache
  • log in as a non-admin user allowed to create ads and access content
  • go to /classified : you should see the "Add one" link again
  • log out
  • go to /classified again: you should still see the "Add one" link, even though clicking on it gives an access denied if you did not allow anonymous users to post ads
  • log in as admin
  • clear cache
  • log out
  • go to /classified again: you should no longer see the Add one link
  • log in as a non admin user allowed to create ads and access content.
  • go to /classified again: you should not see the Add one link either

Can you confirm this matches what you observe on your site ?

The attached patch catches this situation by failing two assertions.

fgm’s picture

Status: Postponed (maintainer needs more info) » Needs review

Status: Needs review » Needs work

The last submitted patch, anonymous-ad-creation_1382234.patch, failed testing.

fgm’s picture

Version: 6.x-3.0-rc2 » 6.x-3.x-dev
Status: Needs work » Needs review

Actually patch is for 6.x-3.x-dev, not RC2.

fgm’s picture

#6: anonymous-ad-creation_1382234.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, anonymous-ad-creation_1382234.patch, failed testing.

fgm’s picture

OK, the 2 failed assertions are what this issue is about, I'll be writing the fix. Hopefully this is the problem met by the people who said that had met that case. Can you follow the steps in #6 to confirm this is what has been happening to you ?

fgm’s picture

Status: Needs work » Needs review
StatusFileSize
new3.34 KB

OK so here is the suggested patch. It passes all tests, but I would still like human checks if you had that problem previously.

fgm’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev
StatusFileSize
new3.42 KB

And here is the matching patch for 7.x-3.x

Status: Needs review » Needs work

The last submitted patch, anonymous-ad-creation_1382234-2-D7.patch, failed testing.

fgm’s picture

(usual qa.d.o. problem for the 2 fails: these tests pass normally everywhere else).

fgm’s picture

Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs work » Fixed

Committed to 6.x-3.x and 7.x-3.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.