please include the bidi.module as a standard module, which could be found here:

http://uniball.dyndns.org/cgi-bin/viewcvs.cgi/www/eglug/modules/bidi.module

This is needed to make arabic function correctly.

Comments

Uwe Hermann’s picture

killes@www.drop.org’s picture

Project: Locale » Drupal core
Version: master »
Component: Code » base system
Category: support » feature

moving to Drupal.

kbahey’s picture

To the original author of the bidi.module:

Please commit it to the contrib respository, and create a project page for it. This way everyone can get it.

Steven’s picture

This is in fact not needed at all for Arabic. It is needed to /mix/ two languages with different text directions. This is a different thing altogether.

The code seems a bit excessive to me: you should use regular expressions for speed, as well as use Unicode character ranges instead of byte-based regexps (use the /u modifier). Finally, the filter settings should be removed, as they are not settings at all. This practice was removed in 4.5.

Also, I'm not sure about the setlocale() call. In my tests, PHP seems to ignore the locale for almost everything.

msameer’s picture

kbahey, Alaa is the original author of the module, It's in his sandbox in the drupal CVS.
I just ported it to drupal 4.5 API.
Infact the module isn't that clean. Alaa is sitting in front of me ATM and he'll reply to this issue.

Best regards,

alaa’s picture

the code is already in my sandbox but as Steven demonstrated its a horrible hack and not really ready to be a proper module.

I never got around to cleaning it or any of the other EGLUG modules up.

yraffah’s picture

Any intensions to enhance this module and update it for 4.7 while also cleaning the code?

LAsan’s picture

Version: » 7.x-dev

Feature request moving to cvs.

jody lynn’s picture

Status: Active » Closed (won't fix)

A module should first exist in contrib before we can discuss adding it to core.