please include the bidi.module as a standard module
Anonymous (not verified) - December 3, 2004 - 01:39
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
please include the bidi.module as a standard module, which could be found here:
http://uniball.dyndns.org/cgi-bin/viewcvs.cgi/www/eglug/modules/bidi.mod...
This is needed to make arabic function correctly.
#1
#2
moving to Drupal.
#3
To the original author of the bidi.module:
Please commit it to the contrib respository, and create a project page for it. This way everyone can get it.
#4
This is in fact not needed at all for Arabic. It is needed to /mix/ two languages with different text directions. This is a different thing altogether.
The code seems a bit excessive to me: you should use regular expressions for speed, as well as use Unicode character ranges instead of byte-based regexps (use the /u modifier). Finally, the filter settings should be removed, as they are not settings at all. This practice was removed in 4.5.
Also, I'm not sure about the setlocale() call. In my tests, PHP seems to ignore the locale for almost everything.
#5
kbahey, Alaa is the original author of the module, It's in his sandbox in the drupal CVS.
I just ported it to drupal 4.5 API.
Infact the module isn't that clean. Alaa is sitting in front of me ATM and he'll reply to this issue.
Best regards,
#6
the code is already in my sandbox but as Steven demonstrated its a horrible hack and not really ready to be a proper module.
I never got around to cleaning it or any of the other EGLUG modules up.
#7
Any intensions to enhance this module and update it for 4.7 while also cleaning the code?
#8
Feature request moving to cvs.