Closed (won't fix)
Project:
Drupal core
Version:
7.x-dev
Component:
base system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
3 Dec 2004 at 01:39 UTC
Updated:
6 Aug 2010 at 21:16 UTC
Comments
Comment #1
Uwe Hermann commentedComment #2
killes@www.drop.org commentedmoving to Drupal.
Comment #3
kbahey commentedTo the original author of the bidi.module:
Please commit it to the contrib respository, and create a project page for it. This way everyone can get it.
Comment #4
Steven commentedThis is in fact not needed at all for Arabic. It is needed to /mix/ two languages with different text directions. This is a different thing altogether.
The code seems a bit excessive to me: you should use regular expressions for speed, as well as use Unicode character ranges instead of byte-based regexps (use the /u modifier). Finally, the filter settings should be removed, as they are not settings at all. This practice was removed in 4.5.
Also, I'm not sure about the setlocale() call. In my tests, PHP seems to ignore the locale for almost everything.
Comment #5
msameer commentedkbahey, Alaa is the original author of the module, It's in his sandbox in the drupal CVS.
I just ported it to drupal 4.5 API.
Infact the module isn't that clean. Alaa is sitting in front of me ATM and he'll reply to this issue.
Best regards,
Comment #6
alaa commentedthe code is already in my sandbox but as Steven demonstrated its a horrible hack and not really ready to be a proper module.
I never got around to cleaning it or any of the other EGLUG modules up.
Comment #7
yraffah commentedAny intensions to enhance this module and update it for 4.7 while also cleaning the code?
Comment #8
LAsan commentedFeature request moving to cvs.
Comment #9
jody lynnA module should first exist in contrib before we can discuss adding it to core.