Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This patch removes a couple of apostrophes while doing an implode in the $filter_string in the _votingapi_get_raw_votes() function.
$filter_string .= " AND v.tag IN ('". implode("','", $tag_list) ."')";
IS REPLACED WITH
$filter_string .= " AND v.tag IN ('" . implode(',',$tag_list) . "')";
Replaces one other instance.
Also, the function currently only supports $tag_list being an array, and so some extra code is added in case a single $tag string is passed into the function.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | votingapi_recalculate_specific_tag_implodeerror.patch | 2.97 KB | KentBye |
| votingapi_implode_fix.patch | 1.37 KB | KentBye |
Comments
Comment #1
KentBye commentedThis patch is a combination of this one as well as this related patch here.
The previous implode patch can stand on it's own, but the other patch is dependent upon this one.
Comment #2
KentBye commentedBumping this up since I see that these implode errors are still in the latest dev version of VotingAPI.
Patch probably needs to be rerolled.
Comment #3
eaton commentedSupport for the 5.x branch of VotingAPI has ended with the release of Drupal 7 and the upcoming release of VotingAPI 7.x-2.4.