array vs. string bug when defining #default_value array for a multiselect

what can I say?

I can say AWESOME!!
lol

Committed to CVS HEAD. Don't think this needs to go in DRUPAL-5 so I'm marking this fixed.

Yes, individual verifiable fixes do belong in 5.

Committed to 5.

i was creating an Annotation module reading Chapter 2 of the April 2007 edition of Apress' Pro Drupal Development. Reading and setting the #default_value of the textarea of in the nodeapi hook (find ### in the code below) did not show anything.

when i used a textfield type, the value was shown. but i needed a textarea. after searching, i found this patch. i reversed the patch and reverted my textfield back to textarea and it worked.

am i doing something wrong?

<?php

// $Id$
/**
* @file
* Lets users add private annotations to nodes.
*
* Adds a text field when a node is displayed
* so that authenticated users may make notes.
*/

/**
* Implementation of hook_menu().
*/
function annotate_menu() {
	$items = array();
	if (1) {
		$items[] = array(
			'path' => 'admin/settings/annotate',
			'title' => t('Annotation settings'),
			'description' => t('Change how annotations behave.'),
			'callback' => 'drupal_get_form',
			'callback arguments' => array('annotate_admin_settings'),
			'access' => user_access('administer site configuration')
		);
	}
	return $items;
}

/**
* Define the settings form.
*/
function annotate_admin_settings() {
	$form['annotate_nodetypes'] = array(
		'#type' => 'checkboxes',
		'#title' => t('Users may annotate these node types'),
		'#options' => node_get_types('names'),
		'#default_value' => variable_get('annotate_nodetypes', array('story')),
		'#description' => t('A text field will be available on these node types to make
		user-specific notes.'),
	);
	$form['array_filter'] = array('#type' => 'hidden');
	return system_settings_form($form);
}

/**
* Implementation of hook_nodeapi().
*/
function annotate_nodeapi(&$node, $op, $teaser, $page) {
	global $db_prefix;
	switch ($op) {
		case 'load':
		case 'view':
			global $user;
			// If only the node summary is being displayed, or if the
			// user is an anonymous user (not logged in), abort.
			if ($teaser || $user->uid == 0) {
				break;
			}
			$types_to_annotate = variable_get('annotate_nodetypes', array('story'));
			if (!in_array($node->type, $types_to_annotate)) {
				break;
			}
			// Add our form as a content item.
			$node->content['annotation_form'] = array(
				'#value' => drupal_get_form('annotate_entry_form', $node),
				'#weight' => 10
			);
			// Get previously saved note, if any.
			$result = db_query("SELECT note FROM {$db_prefix}annotations WHERE uid = %d AND nid = %d", $user->uid, $node->nid);
			$node->annotation = db_result($result);
	}
	#echo "<!-- nodeapi $op -->".$node->annotation;
}

/**
* Define the form for entering an annotation.
*/
function annotate_entry_form($node) {
	$form['annotate'] = array(
		'#type' => 'fieldset',
		'#title' => t('Annotations')
	);
	$form['annotate']['nid'] = array(
		'#type' => 'value',
		'#value' => $node->nid
	);
	$form['annotate']['note'] = array(
		'#type' => 'textarea',
		'#rows' => 5,
		'#title' => t('Notes'),
		'#default_value' => $node->annotation, ### <--- not working
		'#description' => t('Make your personal annotations about this content
		here. Only you (and the site administrator) will be able to see them.')
	);
	$form['annotate']['submit'] = array(
		'#type' => 'submit',
		'#value' => t('Update')
	);
	#echo "<!-- entry_form -->".$node->annotation;
	return $form;
}

/*
* Save the annotation to the database.
*/
function annotate_entry_form_submit($form_id, $form_values) {
	global $user, $db_prefix;
	$nid = $form_values['nid'];
	$note = $form_values['note'];
	db_query("DELETE FROM {$db_prefix}annotations WHERE uid = %d and nid = %d", $user->uid, $nid);
	db_query("INSERT INTO {$db_prefix}annotations (uid, nid, note, timestamp) VALUES (%d, %d, '%s', %d)", $user->uid, $nid, $note, time());
	drupal_set_message(t('Your annotation was saved!'));
}