Hi!

Thanks for this interesting, simple and usefull module!

I tested 7.x version and everything works A-OK ecxept two issues.

After browsing / inserting file through IMCE, I can't insert new files without going to save / preview node because "Add a new file" form disappear.

Before:
Before

After:
After

As you can see, there is no form for inserting new image.. :/

I noticed also if image is removed, I got "Add a new file" form without "Open File Browser" link:
After removing image

CommentFileSizeAuthor
#5 imce_filefield_add-new-issue_after-fix.png60.62 KBizkreny
#3 filefield_add-new-issue_after.png54.47 KBizkreny
imce_filefield_add-new-issue_after-cancel.png16.65 KBizkreny
imce_filefield_add-new-issue_after.png45.99 KBizkreny
imce_filefield_add-new-issue_before.png19.45 KBizkreny

Comments

izkreny’s picture

izkreny commented

Seems that first issue is also appearing in FileField Sources module and D7.9+

#1329056: "Add a new file" form disappear after selecting existing file

ufku’s picture

ufku commented
Status: Active » Postponed (maintainer needs more info)

Unable to reproduce it.
What happens when you use regular upload widget? Any difference with IMCE FFF enabled/disabled?

izkreny’s picture

izkreny commented
Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new filefield_add-new-issue_after.png54.47 KB

When I disable IMCE FFF everything works fine, I got new "Add a new file" form just below uploaded image / file:

After without IMCE FFF

What version of Drupal are you using? As I understand from #1329056: "Add a new file" form disappear after selecting existing file issue, this is problem with 7.10 version, and probably 7.9, but in 7.8 everything work fine with FileField Sources, probably with IMCE FFF too.

My setup is:
Drupal 7.10
Apache/2.2.9 (Debian)
PHP/5.3.8-1~dotdeb.1 with Suhosin-Patch

ufku’s picture

ufku commented
Status: Active » Fixed

I was able to observe it after upgrading.
Committed a patch.
Thanks.

izkreny’s picture

izkreny commented
Status: Fixed » Active
StatusFileSize
new imce_filefield_add-new-issue_after-fix.png60.62 KB

Thx ufku, "Add a new file" form is now present after selecting file, BUT, without "Open File Browser" link. :/
Can you reproduce this behavior too?

Before:
Before

After:
After fix.

ufku’s picture

ufku commented
Status: Active » Postponed (maintainer needs more info)

I can't reproduce it.

izkreny’s picture

izkreny commented
Status: Postponed (maintainer needs more info) » Fixed

You are absolutely right, I can't reproduce it either with only minimum of modules enabled.

Probably some race condition or collision with another module, will try to find out and report in another issue.

Thx again for this fix!

nateb’s picture

nateb commented

I've seen the same error on upgrading to both 7.10 and 7.9. I can't seem to reproduce it through enabling or disabling other modules on those versions. I don't have any problems on 7.8. A brilliant little module.

izkreny’s picture

izkreny commented
Title: "Add a new file" and "Open File Browser" forms disappear » "Add a new file" forms disappear

Disappearing of "Add a new file" form is definitely solved.

I found out that disappearing of "Open File Browser" link is related to Linkit 7.x-2.x module, and will report this in another issue, although it's not probably IMCE FFF fault.

nateb’s picture

nateb commented

In a second attempt at upgrading from 7.8 to 7.10, everything works.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.