Commit http://drupalcode.org/project/ubercart.git/commitdiff/1fa876f changed the Product kit total price field from a textarea to a uc_price form element. Unfortunately, this breaks the total price behavior.
The "Total price" field is supposed to accept either:
1) a number, in which case the individual product discounts are automatically calculated in order to have the sum of the product prices and discounts equal to the entered total price, or
2) a blank, in which case the total price is automatically calculated from the sum of the product prices and entered discounts.
The uc_price form element breaks behavior #2 because it prevents the user from entering a blank - uc_price interprets the blank as a zero, which forces behavior #1.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | discount_qty_data_lost-1385950-2.patch | 797 bytes | millenniumtree |
| #5 | discount_qty_data_lost-1385950-2.patch | 797 bytes | millenniumtree |
| #11 | 1385950-kit-total-price-11.patch | 648 bytes | wodenx |
Comments
Comment #1
millenniumtreeI've moved my comment to it's own issue http://drupal.org/node/1387638 (unrelated)
Comment #2
millenniumtreePlease ignore this patch (unrelated to the issue described)
Comment #4
millenniumtreeComment #5
millenniumtreePlease ignore this patch (unrelated to the issue described)
Comment #7
millenniumtree#5: discount_qty_data_lost-1385950-2.patch queued for re-testing.
Comment #9
millenniumtreeRemoved unrelated comment
Comment #10
tr commentedPlease open a NEW issue if you have a different problem than the one described in the original post. We can't possibly properly manage and track threads that try to deal with many different issues at the same time. The original post is a very clear-cut and narrow problem that can be simply addressed if it does not become cluttered with additional irrelevant information. This issue is a 7.x-3.x issue only, and it does not affect 6.x-2.x.
Please open a new 6.x-2.x issue for your patch. The testbot seems to be having problems right now, which is why the test is failing. But you can run the tests on your own machine to see if your patch breaks anything.
Comment #11
wodenx commentedDoes this fix it?
Comment #12
tr commented#empty_zero ? What's that?
Edit: Oh, I see - it's a custom property we defined on the uc_price element. Let me test to see if that works.
Comment #13
tr commentedYup, that did the trick. Committed to 7.x-3.x.
Comment #14
wodenx commenteduc_store.module, lines 274ff
and 464ff
looks like that last bit was added pretty recently.
Comment #15
tr commentedCrosspost.
Comment #16
millenniumtreeI apologize for cluttering up this issue with an unrelated patch. At first I thought my issue was linked/related to this one - after creating and posting a patch, it became obvious the two were not related, so I've edited all the unrelated comments and moved my issue here http://drupal.org/node/1387638
Trying to help, but I'm fairly new at posting patches. :P
Comment #17.0
(not verified) commentedMade commit # into a link.