There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732 [1]

Review of the 7.x-1.x branch:

    The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags [2]

    ./bean.api.php
    bean.module in bean.info: It's only necessary to declare files[] if they declare a class or interface [3].
    bean.test in bean.info: It's only necessary to declare files[] if they declare a class or interface [3].
    includes/bean.pages.inc in bean.info: It's only necessary to declare files[] if they declare a class or interface [3].
    Remove all old CVS $Id tags, they are not needed anymore.

    bean_admin_ui/bean_admin_ui.info:1:; $Id:$
    bean.info:1:; $Id:$
    Drupal Code Sniffer [4] has found some code style issues (please check the Drupal coding standards [5]). See attachment.

This automated report was generated with PAReview.sh [6], your friendly project application review script. You can also use the online version [7] to check your project. Go and review some other project applications [8], so we can get back to yours sooner.

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
29 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/bean.api.php
--------------------------------------------------------------------------------
FOUND 11 ERROR(S) AFFECTING 10 LINE(S)
--------------------------------------------------------------------------------
4 | ERROR | The second line in the file doc comment must be " * @file"
11 | ERROR | Missing function doc comment
42 | ERROR | Missing parameter type at position 1
43 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 1
44 | ERROR | Doc comment for var $bean does not match actual variable name $op
| | at position 2
44 | ERROR | Missing parameter type at position 2
45 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 2
46 | ERROR | Missing parameter type at position 3
47 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 3
50 | ERROR | Return comment indentation must be 2 additional spaces
65 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/bean.install
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
81 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
149 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...l-7-pareview/sites/all/modules/pareview_temp/test_candidate/bean.module
--------------------------------------------------------------------------------
FOUND 50 ERROR(S) AND 1 WARNING(S) AFFECTING 40 LINE(S)
--------------------------------------------------------------------------------
72 | WARNING | A comma should follow the last multiline array item. Found: )
212 | ERROR | Last parameter comment requires a blank newline after it
212 | ERROR | Superfluous doc comment at position 1
212 | ERROR | Missing parameter type at position 1
235 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
242 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
257 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
270 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
284 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
290 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
295 | ERROR | No space before comment text; expected "// cache_clear_all();"
| | but found "//cache_clear_all();"
295 | ERROR | There must be no blank line following an inline comment
297 | ERROR | No space before comment text; expected "// $core =
| | array('cache', 'cache_filter', 'cache_bootstrap',
| | 'cache_page');" but found "//$core = array('cache',
| | 'cache_filter', 'cache_bootstrap', 'cache_page');"
298 | ERROR | No space before comment text; expected "// $cache_tables =
| | array_merge(module_invoke_all('flush_caches'), $core);" but
| | found "//$cache_tables =
| | array_merge(module_invoke_all('flush_caches'), $core);"
299 | ERROR | No space before comment text; expected "// foreach
| | ($cache_tables as $table) {" but found "//foreach
| | ($cache_tables as $table) {"
301 | ERROR | No space before comment text; expected "// }" but found "//}"
302 | ERROR | No space before comment text; expected "//
| | drupal_flush_all_caches();" but found
| | "//drupal_flush_all_caches();"
303 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
317 | ERROR | Last parameter comment requires a blank newline after it
317 | ERROR | Doc comment for var $plugin does not match actual variable
| | name $plugin_key at position 1
317 | ERROR | Missing parameter type at position 1
317 | ERROR | Parameter comment must be on the next line at position 1
318 | ERROR | Return comment must be on the next line
373 | ERROR | Missing parameter type at position 1
375 | ERROR | Last parameter comment requires a blank newline after it
375 | ERROR | Missing parameter type at position 2
377 | ERROR | Data type of return value is missing
390 | ERROR | Missing parameter type at position 1
392 | ERROR | Last parameter comment requires a blank newline after it
392 | ERROR | Missing parameter type at position 2
394 | ERROR | Data type of return value is missing
419 | ERROR | Missing parameter type at position 1
421 | ERROR | Missing parameter type at position 2
423 | ERROR | Last parameter comment requires a blank newline after it
423 | ERROR | Missing parameter type at position 3
425 | ERROR | Data type of return value is missing
454 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
486 | ERROR | Missing parameter type at position 1
489 | ERROR | Missing parameter type at position 2
492 | ERROR | Last parameter comment requires a blank newline after it
492 | ERROR | Missing parameter type at position 3
500 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
527 | ERROR | Inline comments must start with a capital letter
527 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
553 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
584 | ERROR | Missing parameter type at position 1
587 | ERROR | Data type of return value is missing
598 | ERROR | Missing parameter type at position 1
608 | ERROR | Missing parameter type at position 1
697 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
750 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/bean.tpl.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
7 | WARNING | Line exceeds 80 characters; contains 84 characters
--------------------------------------------------------------------------------

FILE: ...ules/pareview_temp/test_candidate/bean_admin_ui/bean_admin_ui.admin.inc
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AND 1 WARNING(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
25 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
70 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
91 | WARNING | A comma should follow the last multiline array item. Found:
| | $bean_type
125 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
182 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------

FILE: ...odules/pareview_temp/test_candidate/bean_admin_ui/bean_admin_ui.install
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
102 | WARNING | Line exceeds 80 characters; contains 85 characters
--------------------------------------------------------------------------------

FILE: ...modules/pareview_temp/test_candidate/bean_admin_ui/bean_admin_ui.module
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AND 4 WARNING(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
77 | WARNING | Format should be * Implements hook_foo().
83 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
108 | WARNING | Line exceeds 80 characters; contains 82 characters
109 | WARNING | Line exceeds 80 characters; contains 81 characters
110 | WARNING | Line exceeds 80 characters; contains 81 characters
155 | ERROR | Concat operator must be surrounded by spaces
--------------------------------------------------------------------------------

FILE: ...l/modules/pareview_temp/test_candidate/bean_admin_ui/plugins/custom.inc
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
46 | ERROR | Missing function doc comment
53 | ERROR | Doc comment for var [ UNKNOWN ] does not match actual variable
| | name $label at position 1
53 | ERROR | Missing parameter name at position 1
53 | ERROR | Missing comment for param "[ UNKNOWN ]" at position 1
--------------------------------------------------------------------------------

FILE: ...w/sites/all/modules/pareview_temp/test_candidate/includes/bean.core.inc
--------------------------------------------------------------------------------
FOUND 48 ERROR(S) AND 2 WARNING(S) AFFECTING 35 LINE(S)
--------------------------------------------------------------------------------
11 | ERROR | Interface name must begin with a capital letter
11 | ERROR | Interface name must use UpperCamel naming without underscores
19 | ERROR | There must be an empty line before the parameter block
19 | ERROR | Missing parameter type at position 1
19 | ERROR | Parameter comment must be on the next line at position 1
30 | ERROR | There must be an empty line before the parameter block
30 | ERROR | Last parameter comment requires a blank newline after it
30 | ERROR | Missing parameter type at position 1
30 | ERROR | Missing comment for param "$key" at position 1
31 | ERROR | Return comment must be on the next line
39 | ERROR | Missing comment for @return statement
47 | ERROR | Return comment must be on the next line
55 | ERROR | There must be an empty line before the parameter block
55 | ERROR | Missing comment for param "$bean" at position 1
63 | ERROR | Missing comment for @return statement
75 | WARNING | Line exceeds 80 characters; contains 89 characters
77 | ERROR | Missing parameter type at position 1
77 | ERROR | Missing comment for param "$bean" at position 1
78 | ERROR | Missing parameter type at position 2
78 | ERROR | Missing comment for param "$form" at position 2
79 | ERROR | Last parameter comment requires a blank newline after it
79 | ERROR | Missing parameter type at position 3
79 | ERROR | Missing comment for param "$form_state" at position 3
80 | ERROR | Return comment must be on the next line
88 | ERROR | There must be an empty line before the parameter block
88 | ERROR | Missing parameter type at position 1
88 | ERROR | Missing comment for param "$values" at position 1
89 | ERROR | Missing parameter type at position 2
89 | ERROR | Missing comment for param "$form_state" at position 2
98 | ERROR | Missing parameter type at position 1
100 | ERROR | Missing parameter type at position 2
103 | ERROR | Last parameter comment requires a blank newline after it
103 | ERROR | Missing parameter type at position 3
105 | ERROR | Data type of return value is missing
120 | ERROR | Class property $view_mode should use lowerCamel naming without
| | underscores
134 | ERROR | Missing function doc comment
138 | ERROR | Missing function doc comment
139 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
147 | ERROR | You must use "/**" style comments for a function comment
149 | ERROR | Whitespace found at end of line
180 | WARNING | Line exceeds 80 characters; contains 85 characters
280 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
283 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
287 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
298 | ERROR | Whitespace found at end of line
309 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
328 | ERROR | Whitespace found at end of line
334 | ERROR | Missing function doc comment
385 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
443 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...w/sites/all/modules/pareview_temp/test_candidate/includes/bean.info.inc
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
13 | ERROR | Missing function doc comment
59 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: .../sites/all/modules/pareview_temp/test_candidate/includes/bean.pages.inc
--------------------------------------------------------------------------------
FOUND 9 ERROR(S) AND 1 WARNING(S) AFFECTING 9 LINE(S)
--------------------------------------------------------------------------------
47 | ERROR | You must use "/**" style comments for a function comment
62 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
120 | ERROR | Missing parameter type at position 1
138 | WARNING | Line exceeds 80 characters; contains 237 characters
138 | ERROR | No space before comment text; expected "// $output = '' .
| | t('You have not created any block types yet. Go to the block type creation page [9] to add a
| | new bean type.', array('@create-content' =>
| | url('admin/structure/block_types/add'))) . '';" but found
| | "//$output = '' . t('You have not created any block types
| | yet. Go to the block type creation
| | page [9] to add a new bean type.', array('@create-content' =>
| | url('admin/structure/block_types/add'))) . '';"
182 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
210 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
364 | ERROR | Missing function doc comment
425 | ERROR | Missing function doc comment
453 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...ules/pareview_temp/test_candidate/includes/translation.handler.bean.inc
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
16 | ERROR | Missing function doc comment
20 | ERROR | Missing function doc comment
24 | ERROR | Missing function doc comment
27 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/plugins/base.inc
--------------------------------------------------------------------------------
FOUND 10 ERROR(S) AFFECTING 8 LINE(S)
--------------------------------------------------------------------------------
8 | ERROR | Class name must begin with a capital letter
8 | ERROR | Class name must use UpperCamel naming without underscores
9 | ERROR | Class property $plugin_info should use lowerCamel naming without
| | underscores
37 | ERROR | Missing function doc comment
53 | ERROR | Missing function doc comment
79 | ERROR | Missing parameter type at position 1
81 | ERROR | Missing parameter type at position 2
84 | ERROR | Last parameter comment requires a blank newline after it
84 | ERROR | Missing parameter type at position 3
86 | ERROR | Data type of return value is missing
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview [7] - PAReview.sh online service
Source URL: http://ventral.org/pareview/httpgitdrupalorgprojectbeangit-7x-1x

Links:
[1] http://drupal.org/node/1127732
[2] http://drupal.org/node/318#phptags
[3] http://drupal.org/node/542202#files
[4] http://drupal.org/project/drupalcs
[5] http://drupal.org/node/318
[6] http://drupal.org/sandbox/klausi/1320008
[7] http://ventral.org/pareview
[8] http://drupal.org/project/issues/projectapplications?status=8
[9] http://ventral.org/%40create-content

A lot of this is just general cleanup...

Comments

indytechcook’s picture

indytechcook commented

Here is a start. Not all done yet. http://drupal.org/commitlog/commit/22232/4feed25ce58642302f862e52d4c5c02...

This also contains a MAJOR API CHANGE!

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Needs work » Reviewed & tested by the community

For those keeping track, this commit updated API to 4.

If you are writing a plugin and need to find the current API #, look in bean.api.php inside the latest version.

I've run the most recent version of Bean through coder and I'm not getting any warnings or errors so I think we can mark this as resolved.

indytechcook’s picture

indytechcook commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Forgot links.