Hi All
Problem - even when my user terms are filled up completely, PCP still showed the profile as incomplete - giving the user term field as incomplete.
I found the bug in the pcp_get_user_additional_values function. Please find attached a patch which fixes this issue.

Thx
suchi

CommentFileSizeAuthor
pcp.module.patch700 bytesgargsuchi

Comments

grasmash’s picture

grasmash commented
Status: Active » Needs work

Thanks for submitting this patch. Unfortunately, it doesn't seem to be properly formed. For instance, it instructs that "foreach ($user_terms_vocabs as $vid) {" should be removed, but that line doesn't exist in pcp.module.

Can you please roll this patch against 7.x-1.x branch of the git repository? That matches the current 7.x-dev release.

Thanks!

grasmash’s picture

grasmash commented

My bad, didn't realize this what a 6.x issue! I'll roll this patch against the right version.

grasmash’s picture

grasmash commented
Status: Needs work » Closed (fixed)

committed and pushed to dev version 6.x-2.x

BarisW’s picture

BarisW commented
Status: Closed (fixed) » Fixed

Hi Matthew, great work!

Just on a side note: when an issue is solved, please mark them Fixed and don't close them immediately. Doing so makes that they don't show up on the dashboard page anymore. The Drupal bot will close them automatically after two weeks of inactivity.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.