I use views_arg_context 7.x-2.x on every site I build. I just love it, and there's always something handy I can stash for a views argument using it.

As I started yet another site and went to install it (with warm fuzzy feelings all around) I noticed it's still at dev. Then I came here and noticed that there are no issues whatsoever filed against 7.x-2.x.

So... how about a stable release? :) Just putting that out there! If there are any issues or roadblocks or extra work needed, I'd be happy to help out in order to support the cause.

In any case, thank you for this awesome module!

CommentFileSizeAuthor
#7 update_readme-1387444-7.patch6.61 KBalbert volkman
#5 update_readme_for_d7-1387444-5.patch1.07 KBmisc

Issue fork views_arg_context-1387444

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xjm’s picture

xjm
she/her
Primary language English
commented

Hi, @damien_vancouver,

I recently adopted this module from its original creator. I opened the dev branch from a patch that was submitted, and I haven't reviewed or tested it at all. ;) So that's why I haven't created a stable release. Feedback on whether and how D7 is working would help out in that regard, I suppose. Thanks!

damien_vancouver’s picture

damien_vancouver commented

So far it's working perfectly for me on multiple production sites. The only improvements that spring to mind are documentation - more examples and documented suggestions on what hooks to use in what cases would be good. Ditto some more handy built in contexts that could be used (perhaps in a views_arg_context_extras module).

Those are all more functionality enhancements for both versions than problems/issues with the D7 port though.

Usage stats show that D7 installs are at about 20% of the user base now.

Here's a stab at a testing plan:

  1. Test each provided views handler from views-arg_context.views_default.inc works as intended with latest stable 7.x-3.x views version
  2. Test each provided context is setting meaningful values (Xdebug maybe)
  3. Check that nothing in the testing produced PHP warnings or errors
  4. Devel/Coding Standards module review and visual inspection of all code
  5. Review/edit documentation for Drupal 7 accuracy/completeness
  6. What else?

I can do some of this testing once the list is agreed on and report back here. Or any other steps I can do that would help push this along? I realize it may have to wait until you are using it yourself on a D7 site before we actually get a release... but I'll help how I can if I can.

thanks!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

README.txt needs updating for D7, including:

dependencies[] = views
dependencies[] = context
dependencies[] = views_arg_context
core = 6.x

should just be

dependencies[] = views_arg_context
core = 7.x

and

function mysite_helper_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {

should be

function mysite_helper_node_view($node, $view_mode, $langcode) {
xjm’s picture

xjm
she/her
Primary language English
commented
Title: How about a 7.x-2.0 stable release? » Update README.txt for D7
Issue tags: +Novice

Well, #3 would have more properly been a new issue, but might as well repurpose this issue since the snippets are here. :) Tagging novice to create a patch to correct for #3.

Also, feel free to comment if you've done any of the testing from #2.

misc’s picture

misc commented
StatusFileSize
new update_readme_for_d7-1387444-5.patch1.07 KB

Patch for fixes in comment # 3.

misc’s picture

misc commented
Status: Active » Needs review

Ups, forgot the change status, sorry.

albert volkman’s picture

albert volkman commented
StatusFileSize
new update_readme-1387444-7.patch6.61 KB

This patch provides general format cleanup of the readme file.

kaizerking’s picture

kaizerking commented

patch applied successfully,
But this help is not sufficient, as I see that this module also supports entity(profile2) ,More help required for use cases such as this using this module to use for profile2 and field collections
where I wanted to contextual filter jobs(nodes) based on role applicant profile2 fields(terms), and field collection fields where the fields(terms) attached to field collection fields.
I have been trying to get this but no succes
this is much required as in future almost every thing is going to be entities in drupal.

anabpv made their first commit to this issue’s fork.