When using drush make to download the flexslider module and flexslider library it causes issues. drush make does not like having keys be the same across modules, themes, and libraries. We should have the ability to specify what directory to look for the flexslider library.

CommentFileSizeAuthor
#1 1387506-define-library-folder.patch1.72 KBtom friedhof

Comments

tom friedhof’s picture

tom friedhof commented
Status: Active » Needs review
StatusFileSize
new 1387506-define-library-folder.patch1.72 KB

Here is a patch to fix this. I also added a submit button on the "Advanced Settings" tab so you can actually save settings on that page.

spotzero’s picture

spotzero commented
Status: Needs review » Fixed

When downloading libraries with Drush make, you can use the 'directory_name' option to control the name of the directory that the downloaded library is extracted into.

So the drush make code for downloading the flexslider libraries should look something like this:

libraries[flexslider][download][type] = "get"
libraries[flexslider][download][url] = "https://github.com/woothemes/FlexSlider/zipball/master"
libraries[flexslider][directory_name] = "flexslider"
libraries[flexslider][type] = "library"

However, you don't need to worry about any of that, since we will be including a make file inside of the flexslider module. That make file will contain the above code, so just including flexslider in your drush make file will implicitly download the flexslider library.

Thank,

minoroffense’s picture

minoroffense commented
Status: Fixed » Closed (won't fix)

The release includes a make file now. Try it out.

Allowing the folder to be renamed in the UI isn't necessary so I'll just leave this patch alone. Thanks for taking the time though!