Discount for Additional Participants In Event registration.

@jeevajoy, thanks for reporting this. Are you using the "automatic discount" for members and expecting that additional participants would not be allowed to use the discount?

How are you "get the email and via api I check whether he is active member?" Are you writing another module that ties in with the discount module or just hacking it?

If you're just hacking it, how about generating a patch?
If you're writing another module, sorry, you're on your own.

Currently, it does not check if additional participants are members. It would be great if you could supply a patch that checks for that. It might be very difficult to implement via Civi provided hooks. You'll need to see if hook_civicrm_buildAmount() allows you access to additional participants page and then do a lookup if the additional participant is a member. You obviously won't be able to do that until after the form has been submitted. Not trivial.

This is a problem w/additional participants in general and not directly related to memberships.

Don't adjust priority, status, etc. unless you plan to take ownership of the ticket and supply a patch.

I really appreciate you taking the time to work on this, but quite honestly it still needs a lot of work. After a brief code review, here's a list of problems that standout:

1. The module already supports checking if the initial person signing up is a member. You need to address Additional Participants specifically.
2. The JS file you added doesn't seem necessary.
3. You probably shouldn't be getting email from $_GET. You can get everything from $form which is available in buildForm().
4. You're code doesn't properly handle the condition of multiple contact records returned from civicrm_contact_get(). How do you know if you've got the correct contact record?
5. Lastly, your code is very difficult to read especially with the inconsistent spacing. Please refer to Drupal coding standards.

Something to consider, we need a way to enable/disable this functionality. There is a use case for allowing a member to signup additional participants and passing that discount on to them. We have a checkbox at admin/settings/civievent_discount/settings that allows for multiple participants but we aren't really using it anywhere. Perhaps we give two options:

1. If checked, we pass the discount on to additional participants and count as a single use.
2. If not checked, we disable discounts for additional participants unless they supply a code.

Should be possible in the buildAmount() hook. You'll need to find a unique key/value in $form we can use that indicates we're in the additional participants screens. If you var_dump($form) you should be able to find something.

@jeevajoy, any luck making the modifications? If you get stuck and need help, let me know.

$form is an object passed into buildAmount(). If you compare $form when the first participant registers vs. when additional participants register, you should find a unique key. It might be the form name or possibly a key/value pair indicating which additional participant we're on.

I recommend using xdebug w/an interactive debugger. If you don't want to do that, just whatever flavor of var_dump/print_r/dpm you like to compare $form values.

@jeevajoy, were you able to find that $fname == 'CRM_Event_Form_Registration_AdditionalParticipant' in buildAmount()? There's an _allow_multiple() that will tell you whether the discount settings allow multiple participants. That should be all you need.

Fixed in latest -dev release. You may need to wait 24 hours for the update to appear. This has not been fully tested but the "happy path" appears to work perfectly.

The settings page and description has been cleaned up and delicate nature of form processing in buildAmount() has been reworked. This hopefully addresses the broken and ambiguous use of additional participants discounts. There are only two options now:

• enabled and automatic discount to all additional participants
• disabled and no discounts available to additional participants