I use Aegir to manage a bunch of OpenAtrium sites. I updated the 'views' module (because of security alert SA-CONTRIB-2011-052) by putting a new version of 'views' in sites/all/modules (rather than changing it in profiles/openatrium/modules) - which I think is best practice, because that way I can still update to a new version of OpenAtrium by replacing the profile directory.

Anyway, Aegir was building the packages for the profile incorrectly, by having the module in the profile override the module in sites/all/modules (ie. giving the wrong filename, version and schema_version on the hosting_package_instance table) rather than vice-versa.

The net result was that I couldn't Clone or Migrate to a later platform because it thought the schema_version would go backwards.

Attached is a patch that reverses this behavior. After applying the patch and doing a Verify on the platform, the platform comparison and Clone/Migrate start working correctly.

CommentFileSizeAuthor
#1 hostmaster-packages.patch842 bytesdsnopek
hostmaster-packages.patch649 bytesdsnopek

Comments

dsnopek’s picture

Project: Hosting » Hostmaster (Aegir)
Version: 6.x-0.4-alpha3 » 6.x-1.x-dev
StatusFileSize
new842 bytes

Rerolled the patch and hopefully moved to the appropriate issue queue. :-) I hadn't realized that development of the 'hosting' module was taking place in the 'hostmaster' project.

Robin Millette’s picture

Status: Needs review » Reviewed & tested by the community

I noticed the same discrepancy (installed modules vs modules in use) which leads to confusion. I tried the patch on Aegir 1.6 and it seems to be working. It's also consistent with drupal_system_listing(...), respecting precedence of modules.

steven jones’s picture

Thanks for the bug report and the patch, this actually needed a little bit of work on provision too, so that we keeping the priority of the modules correctly.

Fixed in 6.x-1.x in hostmaster and provison

Robin Millette’s picture

Status: Reviewed & tested by the community » Fixed
steven jones’s picture

I was trying to be helpful and link to the commits, because d.o doesn't at the moment, sorry that I didn't get the linking right.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit eb794c5 on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones:
    Issue #1388542 by dsnopek: Fixed packages in sites/all/modules should...

  • Commit eb794c5 on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones:
    Issue #1388542 by dsnopek: Fixed packages in sites/all/modules should...