Closed (won't fix)
Project:
Vote Up/Down
Version:
5.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Apr 2007 at 17:40 UTC
Updated:
11 Jun 2010 at 18:27 UTC
I was trying to move the uservotes page (admin/vote_up_down/usersvotes) under another page, and realized that it (and its parent menu item admin/vote_up_down) are not in the $maycache condition of hook_menu. This means the disappear when you're on the admin/menu page. Unless there is another reason they are in this section that I don't see, they should probably be standard cached menu items so that site admins can freely move them around if needed.
Please note that this as actually in the 4.7 version that I noticed this, but I grabbed head this afternoon to make sure this was still the case.
Comments
Comment #1
frjo commentedDo you know if the MENU_LOCAL_TASK items should be moved under the $maycache condition also?
Comment #2
seanbfuller commentedAs I understand it, cached menu items refer to the path being either static or dynamic. Generally MENU_LOCAL_TASK items or anything with an arg() in the path needs to be in the else condition (!$may_cache). Anything that's just a string goes in the cached condition ($may_cache).
So the short answer is, I think the local task would need to stay in the else condition.
Comment #3
marvil07 commentedPlease take a look to the update on the project page, now
5.xis not-really-maintained.If you think your report is still applicably to the last recommended version(
6.x-2.x) please move the version accordingly and reopen it.