Closed (fixed)
Project:
Views Slideshow JCarousel
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Dec 2011 at 06:03 UTC
Updated:
19 Feb 2012 at 03:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
redndahead commentedComment #2
koglinjg commentedI have been looking at your code and converting it to work in Drupal 7. In doing so I have noticed a few things:
(1) views_slideshow_jcarousel.module;
The files created by this patch are named:
theme/views-slideshow-jcarousel.tpl.php
theme/views-slideshow-jcarousel-field.tpl.php
theme/views-slideshow-jcarousel-item.tpl.php
Those either need to be renamed or changed in the code
(2) views_slideshow_jcarousel.module:
That is defined like this in the theme/views_slideshow_jcarousel.theme.inc:
I will post my code for Drupal 7 when I get get a chance to fix the other issues with it and get it functional.
Comment #3
jjclint commentedAny progress on this?
Comment #4
redndahead commentedI haven't been able to come back to this yet. I'm certainly going to be too busy next week. I'm hoping to circle around to some other projects next week.
Comment #5
raulmuroc commentedsome advance to port to D7?
Just curious, it would be really useful module.
Comment #6
aaron commentedhere's a start
Comment #7
aaron commentedrather this one.
Comment #8
raulmuroc commentedIt doesn't apply:
I've just deleted this section and changed manually, it applied. It is not a clean solution but at least I can test.
I tested the patch.
Comment #9
raulmuroc commentedRepaired patch, it was breaking at line 31 and line 137. I wanted to commit it but I'm new on patching and I'm not sure I'm able to do without special permissions...
Now it is applying but when I acces the Slideshow View, and I click on 'settings' next to Format: Slideshow it returns the following error:
Comment #10
aaron commentedtry this one.
Comment #11
aaron commentedthis one gets us just little further along
Comment #12
aaron commentedHere is my final answer. Seems to work perfectly, and ready for a final review!
Comment #13
raulmuroc commentedIt applies correctly.
For the moment doesn't work to me. I would like to choose a Jcarousel skin but the list appears empty, perhaps here is the error. Should I create a directory?
To me it lets me to set up, but when I save it appears the error:
Comment #14
fearlsgroove commentedThanks. Fixed dependencies/states in views UI, javascript to D7 format and committed. Functional 7.x dev should be up shortly.