Comments

redndahead’s picture

StatusFileSize
new21.71 KB
koglinjg’s picture

I have been looking at your code and converting it to work in Drupal 7. In doing so I have noticed a few things:

(1) views_slideshow_jcarousel.module;

'template' => 'theme/views-slideshow-jcarousel-pager',
'template' => 'theme/views-slideshow-jcarousel-pager-field',
'template' => 'theme/views-slideshow-jcarousel-pager-item',

The files created by this patch are named:
theme/views-slideshow-jcarousel.tpl.php
theme/views-slideshow-jcarousel-field.tpl.php
theme/views-slideshow-jcarousel-item.tpl.php

Those either need to be renamed or changed in the code

(2) views_slideshow_jcarousel.module:

_views_slideshow_jcarousel_pager_preprocess_pager_item($vars);

That is defined like this in the theme/views_slideshow_jcarousel.theme.inc:

function _views_slideshow_jcarousel_preprocess_pager_item(&$vars) {

I will post my code for Drupal 7 when I get get a chance to fix the other issues with it and get it functional.

jjclint’s picture

Any progress on this?

redndahead’s picture

I haven't been able to come back to this yet. I'm certainly going to be too busy next week. I'm hoping to circle around to some other projects next week.

raulmuroc’s picture

Version: » 6.x-1.x-dev

some advance to port to D7?

Just curious, it would be really useful module.

aaron’s picture

Title: Initial Patch » Upgrade Views Slideshow JCarousel to d7
StatusFileSize
new6.5 KB

here's a start

aaron’s picture

rather this one.

raulmuroc’s picture

It doesn't apply:

Checking patch theme/views_slideshow_jcarousel.theme.inc...
Checking patch views_slideshow_jcarousel.info...
error: while searching for:
description = Adds a jCarousel option to views slideshow
dependencies[] = views_slideshow
package = Views
core = 6.x

error: patch failed: views_slideshow_jcarousel.info:2
error: views_slideshow_jcarousel.info: patch does not apply
Checking patch views_slideshow_jcarousel.module...

I've just deleted this section and changed manually, it applied. It is not a clean solution but at least I can test.

I tested the patch.

raulmuroc’s picture

Repaired patch, it was breaking at line 31 and line 137. I wanted to commit it but I'm new on patching and I'm not sure I'm able to do without special permissions...

Now it is applying but when I acces the Slideshow View, and I click on 'settings' next to Format: Slideshow it returns the following error:

An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /admin/structure/views/ajax/display/slideshow/block/style_options
StatusText: error
ResponseText:

aaron’s picture

try this one.

aaron’s picture

this one gets us just little further along

aaron’s picture

Here is my final answer. Seems to work perfectly, and ready for a final review!

raulmuroc’s picture

It applies correctly.
For the moment doesn't work to me. I would like to choose a Jcarousel skin but the list appears empty, perhaps here is the error. Should I create a directory?

To me it lets me to set up, but when I save it appears the error:

An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /admin/structure/views/view/slideshow/preview/block/ajax
StatusText: error
ResponseText:

And the slideshow on the page disappears completely.

fearlsgroove’s picture

Status: Needs review » Fixed

Thanks. Fixed dependencies/states in views UI, javascript to D7 format and committed. Functional 7.x dev should be up shortly.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.