In preparation of letting imagefield use the "filefield API", this patch renames 'remove' to 'delete' (also in the user visible strings). The plan is to unify the structure of the $file array, which I intend to do by using $file['delete'] instead of $file['remove'] in filefield, and instead of $file['flags']['delete'] in imagefield. When both are done, $file arrays can be passed between filefield and imagefield functions without any doubts that it might not work.
Applies to plain HEAD.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | filefield-delete-not-remove-try3.patch | 3.22 KB | jpetso |
| #3 | filefield-delete-not-remove-try2.patch | 3.25 KB | jpetso |
| filefield-delete-not-remove.patch | 3.05 KB | jpetso |
Comments
Comment #1
jpetso commentedAh right, the reasons why I prefer 'delete' over 'remove':
Comment #2
drewish commented+1, we should bring the verbiage into line with core.
Comment #3
jpetso commentedRerolled for current HEAD.
Comment #4
jpetso commentedEr, it's still $node_field, not $items. Don't know where I got that from. Also, improve the deletion validation text so that it's more future proof.
Comment #5
jpetso commentedCommitted to filefield HEAD. Yay, makes the 'required' setting actually work.
Comment #6
(not verified) commented