Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I have disabled and uninstalled theme dev and later found that it keeps filling the log with the message:
Theme key "placeholder" not found.
The messages get logged each time I edit a view (??).
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1389430--Change-logging-source-to-avoid-confusion-with-cores-theme.inc_.patch | 956 bytes | amontero |
Comments
Comment #1
amonteroMy fault, not a theme_developer issue.
I was wrong because I found the string inside the modules dir when grepping for it.
It is also in 'includes/theme.inc' and by deleting the module the messages keep appearing.
Obviously, I was blaming the wrong module.
Patched module to help distinguish messages in log.
Comment #2
eojthebraveTbis is a super simple fix and makes sense. Documentation for watchdog() even suggests using the module name as the $type argument.
Comment #3
kenneth.venken commenteddevel_themer_theme_twin should behave exactly like the core theme() function. Changing the watchdog source, changes the behaviour of the theme function. Is there any merit in being able to distinguish between the two sources?
Comment #4
amonteroI'm no theme developer, so I'm not sure if distinguishing the true source would be of any benefit. As I've been banging my head for a while, seemed to me worthwile to patch in case somebody else runs on the same when troubleshooting a site.
Using different source can help some admins unfamiliar with theming like me making obvious where is the source of the trouble. I also think as #2, too.
Again, I'm not familiar with theming, but IMHO, it can't hurt not replicating the behavior of theme() core just for this and avoid confusion.
My 2c.
Comment #5
amonteroBumping, just in case closed issues do not notify.
Comment #6
kenneth.venken commentedMaybe the error message should be improved to be more descriptive.
This should probably be moved to core.
Theme key "placeholder" not found means that the placeholder.tpl.php or theme_placeholder() couldn't be found.
Comment #7
jason.fisher commentedAgree that this should be moved to core .. my cron mail log would appreciate it .. ;)
Comment #8
kenneth.venken commentedMoving to core as this is a won't fix for theme developer for now.
Comment #9
amonteroI still think that devel_themer_theme_twin function can mimic core's one but worthwhile having a distinguishable message to just avoid anyone else mistakenly look at the wrong place like I did. This won't impair theme_developer functionality and seems an easy solution IMO, too.
I think improving the message would not solve anything, since devel_themer_theme_twin would reflect that change as a twin, would't it? In case core's message could be improved it should be another different issue.
Anyway, I'm not 100% about it, so maybe some core people take is needed. Note that "Drupal core" and not "core" is the appropiate project. Not sure if against 7.x or 8.x.
Comment #10
kenneth.venken commentedOk, i give in ;). Committed to 7.x-1.x